* [PATCH] testrun.sh: Improve --help message
@ 2021-05-03 21:22 Lucas A. M. Magalhaes
2021-05-10 13:39 ` Carlos O'Donell
0 siblings, 1 reply; 4+ messages in thread
From: Lucas A. M. Magalhaes @ 2021-05-03 21:22 UTC (permalink / raw)
To: libc-alpha
The testrun.sh --help message was missing the "container" option.
Besides just adding the missing option I decide to rewrite it in the
same layout as other tools.
---
Makefile | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 50f99ca611..242d36de91 100644
--- a/Makefile
+++ b/Makefile
@@ -144,8 +144,13 @@ builddir=`dirname "$$0"`
GCONV_PATH="$${builddir}/iconvdata"
usage () {
- echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
- echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
+cat << EOF
+Usage: $$0 [OPTIONS] <program> [ARGUMENTS...]
+
+ --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or
+ container. The container will run within support/test-container.
+EOF
+
exit 1
}
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] testrun.sh: Improve --help message
2021-05-03 21:22 [PATCH] testrun.sh: Improve --help message Lucas A. M. Magalhaes
@ 2021-05-10 13:39 ` Carlos O'Donell
2021-05-11 12:19 ` Lucas A. M. Magalhaes
0 siblings, 1 reply; 4+ messages in thread
From: Carlos O'Donell @ 2021-05-10 13:39 UTC (permalink / raw)
To: Lucas A. M. Magalhaes, libc-alpha
On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote:
> The testrun.sh --help message was missing the "container" option.
> Besides just adding the missing option I decide to rewrite it in the
> same layout as other tools.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> Makefile | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 50f99ca611..242d36de91 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -144,8 +144,13 @@ builddir=`dirname "$$0"`
> GCONV_PATH="$${builddir}/iconvdata"
>
> usage () {
> - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
> - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
> +cat << EOF
> +Usage: $$0 [OPTIONS] <program> [ARGUMENTS...]
> +
> + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or
> + container. The container will run within support/test-container.
> +EOF
> +
> exit 1
> }
>
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] testrun.sh: Improve --help message
2021-05-10 13:39 ` Carlos O'Donell
@ 2021-05-11 12:19 ` Lucas A. M. Magalhaes
2021-05-25 4:52 ` Siddhesh Poyarekar
0 siblings, 1 reply; 4+ messages in thread
From: Lucas A. M. Magalhaes @ 2021-05-11 12:19 UTC (permalink / raw)
To: Carlos O'Donell, libc-alpha
Hi Carlos. Can you push this for me?
Quoting Carlos O'Donell (2021-05-10 10:39:57)
> On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote:
> > The testrun.sh --help message was missing the "container" option.
> > Besides just adding the missing option I decide to rewrite it in the
> > same layout as other tools.
>
> LGTM.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
> > ---
> > Makefile | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 50f99ca611..242d36de91 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -144,8 +144,13 @@ builddir=`dirname "$$0"`
> > GCONV_PATH="$${builddir}/iconvdata"
> >
> > usage () {
> > - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
> > - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
> > +cat << EOF
> > +Usage: $$0 [OPTIONS] <program> [ARGUMENTS...]
> > +
> > + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or
> > + container. The container will run within support/test-container.
> > +EOF
> > +
> > exit 1
> > }
> >
> >
>
>
> --
> Cheers,
> Carlos.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] testrun.sh: Improve --help message
2021-05-11 12:19 ` Lucas A. M. Magalhaes
@ 2021-05-25 4:52 ` Siddhesh Poyarekar
0 siblings, 0 replies; 4+ messages in thread
From: Siddhesh Poyarekar @ 2021-05-25 4:52 UTC (permalink / raw)
To: Lucas A. M. Magalhaes, Carlos O'Donell, libc-alpha
On 5/11/21 5:49 PM, Lucas A. M. Magalhaes via Libc-alpha wrote:
> Hi Carlos. Can you push this for me?
>
I've pushed this now.
Siddhesh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-25 4:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 21:22 [PATCH] testrun.sh: Improve --help message Lucas A. M. Magalhaes
2021-05-10 13:39 ` Carlos O'Donell
2021-05-11 12:19 ` Lucas A. M. Magalhaes
2021-05-25 4:52 ` Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).