From: Lukasz Majewski <lukma@denx.de>
To: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Cc: "Florian Weimer" <fweimer@redhat.com>,
"Fāng-ruì Sòng" <maskray@google.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"Patches and discussions about the oe-core layer"
<openembedded-core@lists.openembedded.org>,
"Andreas Schwab" <schwab@linux-m68k.org>,
"Joseph Myers" <joseph@codesourcery.com>,
"Carlos O'Donell" <carlos@redhat.com>
Subject: Re: [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM
Date: Mon, 25 Oct 2021 20:25:42 +0200 [thread overview]
Message-ID: <20211025202542.38a79fc9@ktm> (raw)
In-Reply-To: <20211025150904.GO1982710@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]
Hi Szabolcs,
> The 10/25/2021 16:04, Lukasz Majewski wrote:
> > > > > Either fix the prelink tool not to prelink shared objects
> > > > > that do not have a dependency on libc.so.6, or fix the
> > > > > dynamic loader to work if prelinked on AArch64.
> > > >
> > > > Just for the correctness - both 64 and 32 bit ARMs are
> > > > affected.
> > >
> > > last time i looked, prelinking did not support tlsdesc
> > > correctly so it is unusable for aarch64.
> > >
> > > does yocto/oe use prelinking on aarch64?
> >
> > I think yes - the
> > USER_CLASSES ?= "buildstats image-prelink"
> >
> > is added by default to local.conf
>
> ok, i think we need the patches upstream for that like
> https://sourceware.org/pipermail/libc-alpha/2015-November/066153.html
>
Oh... I see.
> > > > > I do not have a strong opinion.
> > > >
> > > > Thanks for your opinion. Let's wait for other community members
> > > > opinions.
> > >
> > > i think fixing the arm load address computation makes
> > > sense (small extra cost of a relative reloc). i think
> > > the c code proposal i made in the thread is nicer than
> > > the old asm.
> > >
> > > (i'm happy to make the same change on aarch64 too if
> > > prelinking is used there, but i think that's broken.)
> >
> > +1
>
> since you have a prelink setup, can you prepare the
> arm and aarch64 patches?
>
I can prepare the patch - no problem.
Beforehand, I would like to hear from the community if we do have a
consensus about this solution...
> (i suspect x86 would need the same fix, but probably
> prelink is not used there anymore..?)
I do assume that in yocto at least it would use prelink by default as
well.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-25 18:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 13:16 [PATCH] dl: Use "adr" assembler command to get proper load address Lukasz Majewski
2021-09-07 16:49 ` Fangrui Song
2021-09-07 17:32 ` Lukasz Majewski
2021-09-07 17:44 ` Fangrui Song
2021-09-08 15:05 ` Lukasz Majewski
2021-09-08 17:41 ` Fāng-ruì Sòng
2021-09-08 19:19 ` Adhemerval Zanella
2021-09-08 20:34 ` Lukasz Majewski
2021-09-09 7:18 ` Lukasz Majewski
2021-09-09 9:49 ` Lukasz Majewski
2021-09-10 10:10 ` Lukasz Majewski
2021-09-17 8:29 ` Lukasz Majewski
2021-09-17 13:27 ` Joseph Myers
2021-09-17 16:17 ` Andreas Schwab
2021-09-26 19:58 ` Lukasz Majewski
2021-09-27 16:00 ` Joseph Myers
2021-10-05 7:45 ` Lukasz Majewski
2021-10-06 7:57 ` Fangrui Song
2021-10-06 9:03 ` Lukasz Majewski
2021-10-06 11:43 ` Lukasz Majewski
2021-10-06 12:55 ` Szabolcs Nagy
2021-10-07 9:19 ` Lukasz Majewski
2021-10-07 10:00 ` Lukasz Majewski
2021-10-07 14:15 ` Szabolcs Nagy
2021-10-07 14:58 ` Lukasz Majewski
2021-10-07 14:16 ` Adhemerval Zanella
2021-10-07 14:29 ` H.J. Lu
2021-10-07 15:57 ` Szabolcs Nagy
2021-10-07 16:22 ` H.J. Lu
2021-10-07 16:53 ` Adhemerval Zanella
2021-10-07 17:05 ` H.J. Lu
2021-10-07 17:24 ` Fāng-ruì Sòng
2021-10-08 9:15 ` Szabolcs Nagy
2021-10-11 8:56 ` Lukasz Majewski
2021-10-11 10:18 ` Szabolcs Nagy
2021-10-11 11:47 ` Lukasz Majewski
2021-10-11 12:01 ` H.J. Lu
2021-10-11 13:10 ` Lukasz Majewski
2021-10-11 13:22 ` H.J. Lu
2021-10-11 14:31 ` Lukasz Majewski
2021-10-11 13:34 ` Adhemerval Zanella
2021-10-11 12:48 ` Szabolcs Nagy
2021-10-15 7:54 ` [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM Lukasz Majewski
2021-10-15 12:09 ` Szabolcs Nagy
2021-10-15 12:21 ` H.J. Lu
2021-10-15 12:59 ` Lukasz Majewski
2021-10-15 23:53 ` Fāng-ruì Sòng
2021-10-18 11:08 ` Szabolcs Nagy
2021-10-18 11:35 ` Florian Weimer
2021-10-19 12:03 ` Lukasz Majewski
2021-10-25 10:18 ` Lukasz Majewski
2021-10-25 10:25 ` Florian Weimer
2021-10-25 10:53 ` Lukasz Majewski
2021-10-25 13:34 ` Szabolcs Nagy
2021-10-25 14:04 ` Lukasz Majewski
2021-10-25 15:09 ` Szabolcs Nagy
2021-10-25 17:26 ` Joseph Myers
2021-10-26 13:52 ` Lukasz Majewski
2021-10-26 20:55 ` Joseph Myers
2021-10-27 9:38 ` Szabolcs Nagy
2021-10-25 18:25 ` Lukasz Majewski [this message]
2021-10-15 13:59 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025202542.38a79fc9@ktm \
--to=lukma@denx.de \
--cc=Szabolcs.Nagy@arm.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).