* [PATCH] x86: Use CHECK_FEATURE_PRESENT on PCONFIG
@ 2022-01-26 20:28 H.J. Lu
2022-02-12 15:51 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2022-01-26 20:28 UTC (permalink / raw)
To: libc-alpha
PCONFIG is a privileged instruction. Use CHECK_FEATURE_PRESENT, instead
of CHECK_FEATURE_ACTIVE, on PCONFIG in tst-cpu-features-supports.c.
---
sysdeps/x86/tst-cpu-features-supports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
index 46b2c7bf83..997b641449 100644
--- a/sysdeps/x86/tst-cpu-features-supports.c
+++ b/sysdeps/x86/tst-cpu-features-supports.c
@@ -143,7 +143,7 @@ do_test (int argc, char **argv)
fails += CHECK_FEATURE_ACTIVE (movdiri, MOVDIRI);
fails += CHECK_FEATURE_ACTIVE (movdir64b, MOVDIR64B);
fails += CHECK_FEATURE_ACTIVE (osxsave, OSXSAVE);
- fails += CHECK_FEATURE_ACTIVE (pconfig, PCONFIG);
+ fails += CHECK_FEATURE_PRESENT (pconfig, PCONFIG);
fails += CHECK_FEATURE_ACTIVE (pku, PKU);
#endif
fails += CHECK_FEATURE_ACTIVE (popcnt, POPCNT);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT on PCONFIG
2022-01-26 20:28 [PATCH] x86: Use CHECK_FEATURE_PRESENT on PCONFIG H.J. Lu
@ 2022-02-12 15:51 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2022-02-12 15:51 UTC (permalink / raw)
To: GNU C Library
On Wed, Jan 26, 2022 at 12:28 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> PCONFIG is a privileged instruction. Use CHECK_FEATURE_PRESENT, instead
> of CHECK_FEATURE_ACTIVE, on PCONFIG in tst-cpu-features-supports.c.
> ---
> sysdeps/x86/tst-cpu-features-supports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
> index 46b2c7bf83..997b641449 100644
> --- a/sysdeps/x86/tst-cpu-features-supports.c
> +++ b/sysdeps/x86/tst-cpu-features-supports.c
> @@ -143,7 +143,7 @@ do_test (int argc, char **argv)
> fails += CHECK_FEATURE_ACTIVE (movdiri, MOVDIRI);
> fails += CHECK_FEATURE_ACTIVE (movdir64b, MOVDIR64B);
> fails += CHECK_FEATURE_ACTIVE (osxsave, OSXSAVE);
> - fails += CHECK_FEATURE_ACTIVE (pconfig, PCONFIG);
> + fails += CHECK_FEATURE_PRESENT (pconfig, PCONFIG);
> fails += CHECK_FEATURE_ACTIVE (pku, PKU);
> #endif
> fails += CHECK_FEATURE_ACTIVE (popcnt, POPCNT);
> --
> 2.34.1
>
I will check in this next Monday to fix the test on Intel Alder Lake.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-12 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 20:28 [PATCH] x86: Use CHECK_FEATURE_PRESENT on PCONFIG H.J. Lu
2022-02-12 15:51 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).