* [PATCH] Fix elf/loadfail test build dependencies
@ 2022-01-28 13:36 Szabolcs Nagy
2022-01-28 17:20 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Szabolcs Nagy @ 2022-01-28 13:36 UTC (permalink / raw)
To: libc-alpha
There was no direct or indirect make dependency on testobj3.so so the
test could fail with
/B/elf/loadfail: failed to load shared object: testobj3.so: cannot open
shared object file: No such file or directory
---
elf/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/elf/Makefile b/elf/Makefile
index 718e826290..1fa1a519a5 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -1468,7 +1468,9 @@ preloadtest-ENV = \
LDFLAGS-loadfail = -rdynamic
-$(objpfx)loadfail.out: $(objpfx)failobj.so
+$(objpfx)loadfail.out: $(objpfx)failobj.so $(objpfx)testobj1.so \
+ $(objpfx)testobj2.so $(objpfx)testobj3.so \
+ $(objpfx)testobj4.so $(objpfx)testobj5.so
LDFLAGS-multiload = -rdynamic
CFLAGS-multiload.c += -DOBJDIR=\"$(elf-objpfx)\"
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix elf/loadfail test build dependencies
2022-01-28 13:36 [PATCH] Fix elf/loadfail test build dependencies Szabolcs Nagy
@ 2022-01-28 17:20 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2022-01-28 17:20 UTC (permalink / raw)
To: Szabolcs Nagy, libc-alpha
On 1/28/22 08:36, Szabolcs Nagy via Libc-alpha wrote:
> There was no direct or indirect make dependency on testobj3.so so the
> test could fail with
>
> /B/elf/loadfail: failed to load shared object: testobj3.so: cannot open
> shared object file: No such file or directory
Good catch. OK for glibc 2.35.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> elf/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 718e826290..1fa1a519a5 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -1468,7 +1468,9 @@ preloadtest-ENV = \
>
> LDFLAGS-loadfail = -rdynamic
>
> -$(objpfx)loadfail.out: $(objpfx)failobj.so
> +$(objpfx)loadfail.out: $(objpfx)failobj.so $(objpfx)testobj1.so \
> + $(objpfx)testobj2.so $(objpfx)testobj3.so \
> + $(objpfx)testobj4.so $(objpfx)testobj5.so
>
> LDFLAGS-multiload = -rdynamic
> CFLAGS-multiload.c += -DOBJDIR=\"$(elf-objpfx)\"
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-28 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 13:36 [PATCH] Fix elf/loadfail test build dependencies Szabolcs Nagy
2022-01-28 17:20 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).