public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 09/11] alloc_buffer: Apply asm redirection before first use
Date: Fri, 28 Oct 2022 14:35:30 -0300	[thread overview]
Message-ID: <20221028173532.876027-10-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20221028173532.876027-1-adhemerval.zanella@linaro.org>

Compilers may not be able to apply asm redirections to functions after
these functions are used for the first time, e.g. clang 13.
---
 include/alloc_buffer.h | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/include/alloc_buffer.h b/include/alloc_buffer.h
index 1c1dbe0a46..553de607e8 100644
--- a/include/alloc_buffer.h
+++ b/include/alloc_buffer.h
@@ -114,6 +114,9 @@ enum
 
 /* Internal function.  Terminate the process using __libc_fatal.  */
 void __libc_alloc_buffer_create_failure (void *start, size_t size);
+#ifndef _ISOMAC
+libc_hidden_proto (__libc_alloc_buffer_create_failure)
+#endif
 
 /* Create a new allocation buffer.  The byte range from START to START
    + SIZE - 1 must be valid, and the allocation buffer allocates
@@ -132,6 +135,9 @@ alloc_buffer_create (void *start, size_t size)
 /* Internal function.  See alloc_buffer_allocate below.  */
 struct alloc_buffer __libc_alloc_buffer_allocate (size_t size, void **pptr)
   __attribute__ ((nonnull (2)));
+#ifndef _ISOMAC
+libc_hidden_proto (__libc_alloc_buffer_allocate)
+#endif
 
 /* Allocate a buffer of SIZE bytes using malloc.  The returned buffer
    is in a failed state if malloc fails.  *PPTR points to the start of
@@ -333,6 +339,9 @@ void * __libc_alloc_buffer_alloc_array (struct alloc_buffer *buf,
 					size_t size, size_t align,
 					size_t count)
   __attribute__ ((nonnull (1)));
+#ifndef _ISOMAC
+libc_hidden_proto (__libc_alloc_buffer_alloc_array)
+#endif
 
 /* Obtain a TYPE * pointer to an array of COUNT objects in BUF of
    TYPE.  Consume these bytes from the buffer.  Return NULL and mark
@@ -349,6 +358,9 @@ void * __libc_alloc_buffer_alloc_array (struct alloc_buffer *buf,
 struct alloc_buffer __libc_alloc_buffer_copy_bytes (struct alloc_buffer,
 						    const void *, size_t)
   __attribute__ ((nonnull (2)));
+#ifndef _ISOMAC
+libc_hidden_proto (__libc_alloc_buffer_copy_bytes)
+#endif
 
 /* Copy SIZE bytes starting at SRC into the buffer.  If there is not
    enough room in the buffer, the buffer is marked as failed.  No
@@ -363,6 +375,9 @@ alloc_buffer_copy_bytes (struct alloc_buffer *buf, const void *src, size_t size)
 struct alloc_buffer __libc_alloc_buffer_copy_string (struct alloc_buffer,
 						     const char *)
   __attribute__ ((nonnull (2)));
+#ifndef _ISOMAC
+libc_hidden_proto (__libc_alloc_buffer_copy_string)
+#endif
 
 /* Copy the string at SRC into the buffer, including its null
    terminator.  If there is not enough room in the buffer, the buffer
@@ -377,12 +392,4 @@ alloc_buffer_copy_string (struct alloc_buffer *buf, const char *src)
   return result;
 }
 
-#ifndef _ISOMAC
-libc_hidden_proto (__libc_alloc_buffer_alloc_array)
-libc_hidden_proto (__libc_alloc_buffer_allocate)
-libc_hidden_proto (__libc_alloc_buffer_copy_bytes)
-libc_hidden_proto (__libc_alloc_buffer_copy_string)
-libc_hidden_proto (__libc_alloc_buffer_create_failure)
-#endif
-
 #endif /* _ALLOC_BUFFER_H */
-- 
2.34.1


  parent reply	other threads:[~2022-10-28 17:35 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 17:35 [PATCH 00/11] Initial fixes for clang build support Adhemerval Zanella
2022-10-28 17:35 ` [PATCH 01/11] stdlib/longlong.h: Remove incorrect lvalue to rvalue conversion from asm output constraints Adhemerval Zanella
2022-10-28 21:05   ` Joseph Myers
2022-10-28 21:32     ` Fangrui Song
2022-10-31 18:32       ` Adhemerval Zanella Netto
2022-11-01 13:56         ` Adhemerval Zanella Netto
2022-11-01 14:18           ` Joseph Myers
2022-11-01 17:05             ` Adhemerval Zanella Netto
2022-11-02 15:14               ` Cristian Rodríguez
2022-11-02 17:10                 ` Adhemerval Zanella Netto
2022-11-02 19:43                   ` Cristian Rodríguez
2022-11-03 12:17                     ` Adhemerval Zanella Netto
2022-11-01 17:11   ` Andrew Pinski
2022-11-06 19:30     ` Fangrui Song
2022-11-06 19:32     ` Fangrui Song
2022-11-07 13:39       ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 02/11] Disable __USE_EXTERN_INLINES for clang Adhemerval Zanella
2022-10-28 21:06   ` Joseph Myers
2022-10-28 22:02     ` Fangrui Song
2022-10-31 18:33       ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 03/11] Rewrite find_cxx_header config configure.ac Adhemerval Zanella
2022-10-29  4:03   ` Fangrui Song
2022-10-31 19:30     ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 04/11] linux: Move hidden_proto before static inline usage on not-cancel.h Adhemerval Zanella
2022-10-29  4:23   ` Fangrui Song
2022-10-31 19:48     ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c Adhemerval Zanella
2022-10-29  0:44   ` Fangrui Song
2022-10-31 19:54     ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 06/11] Disable use of -fsignaling-nans if compiler does not support it Adhemerval Zanella
2022-10-29  4:19   ` Fangrui Song
2022-10-31 20:01     ` Fangrui Song
2022-10-28 17:35 ` [PATCH 07/11] stdlib: Move attribute_hidden definition to function prototype at gmp.h Adhemerval Zanella
2022-10-29  4:37   ` Fangrui Song
2022-10-31 19:55     ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 08/11] configure: Use -Wno-ignored-attributes if compiler warns about multiple aliases Adhemerval Zanella
2022-10-29  5:59   ` Fangrui Song
2022-10-31 19:59     ` Adhemerval Zanella Netto
2022-10-31 20:11       ` Fangrui Song
2022-10-28 17:35 ` Adhemerval Zanella [this message]
2022-10-29  0:32   ` [PATCH 09/11] alloc_buffer: Apply asm redirection before first use Fangrui Song
2022-10-31 20:01     ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 10/11] allocate_once: " Adhemerval Zanella
2022-10-29  0:34   ` Fangrui Song
2022-10-28 17:35 ` [PATCH 11/11] nptl: Fix pthread_create.c build with clang Adhemerval Zanella
2022-10-29  4:51   ` Fangrui Song
2022-10-31 20:03     ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028173532.876027-10-adhemerval.zanella@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).