From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: "Cristian Rodríguez" <crrodriguez@opensuse.org>
Cc: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 01/11] stdlib/longlong.h: Remove incorrect lvalue to rvalue conversion from asm output constraints
Date: Thu, 3 Nov 2022 09:17:33 -0300 [thread overview]
Message-ID: <8f5afa2a-f5ba-cf87-3f81-49661d802f83@linaro.org> (raw)
In-Reply-To: <CAPBLoAeMQBHJU77ThNkcmLrk8y06gvW3aGQD6tgkO5vB4NqVTA@mail.gmail.com>
On 02/11/22 16:43, Cristian Rodríguez wrote:
> On Wed, Nov 2, 2022 at 2:10 PM Adhemerval Zanella Netto
> <adhemerval.zanella@linaro.org> wrote:
>>
>>
>>
>> On 02/11/22 12:14, Cristian Rodríguez wrote:
>>> On Tue, Nov 1, 2022 at 2:06 PM Adhemerval Zanella Netto via Libc-alpha
>>> <libc-alpha@sourceware.org> wrote:
>>>
>>>> I am open to suggestions in fact,
>>>
>>> What about just using the compiler builtins directly and not using
>>> this header at all?
>>
>> My understanding is this header should be used in the scenario where the
>> builtin might generate libcalls, for instance on libgcc and/or libc.
>
> My - I confess very limited - research the other day suggests there
> are very few targets without __clz* __ctz__ patterns.. On this case it
> will indeed call libgcc (is that frowned upon still?) but not libc ...
This header is also quite ancient, I think it provided the counter leading
and trailing zero even before the ctz/clz builtins and before ffs libc function.
But I agree with you that builtins should be used when possible.
Another issue is the ctz/clz analogous is not the only interface it provides,
but also a some macros used extensively on some soft-fp routines. We will
also need to rewrite a lot of interfaces, which is shared with gcc as well.
next prev parent reply other threads:[~2022-11-03 12:17 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 17:35 [PATCH 00/11] Initial fixes for clang build support Adhemerval Zanella
2022-10-28 17:35 ` [PATCH 01/11] stdlib/longlong.h: Remove incorrect lvalue to rvalue conversion from asm output constraints Adhemerval Zanella
2022-10-28 21:05 ` Joseph Myers
2022-10-28 21:32 ` Fangrui Song
2022-10-31 18:32 ` Adhemerval Zanella Netto
2022-11-01 13:56 ` Adhemerval Zanella Netto
2022-11-01 14:18 ` Joseph Myers
2022-11-01 17:05 ` Adhemerval Zanella Netto
2022-11-02 15:14 ` Cristian Rodríguez
2022-11-02 17:10 ` Adhemerval Zanella Netto
2022-11-02 19:43 ` Cristian Rodríguez
2022-11-03 12:17 ` Adhemerval Zanella Netto [this message]
2022-11-01 17:11 ` Andrew Pinski
2022-11-06 19:30 ` Fangrui Song
2022-11-06 19:32 ` Fangrui Song
2022-11-07 13:39 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 02/11] Disable __USE_EXTERN_INLINES for clang Adhemerval Zanella
2022-10-28 21:06 ` Joseph Myers
2022-10-28 22:02 ` Fangrui Song
2022-10-31 18:33 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 03/11] Rewrite find_cxx_header config configure.ac Adhemerval Zanella
2022-10-29 4:03 ` Fangrui Song
2022-10-31 19:30 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 04/11] linux: Move hidden_proto before static inline usage on not-cancel.h Adhemerval Zanella
2022-10-29 4:23 ` Fangrui Song
2022-10-31 19:48 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c Adhemerval Zanella
2022-10-29 0:44 ` Fangrui Song
2022-10-31 19:54 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 06/11] Disable use of -fsignaling-nans if compiler does not support it Adhemerval Zanella
2022-10-29 4:19 ` Fangrui Song
2022-10-31 20:01 ` Fangrui Song
2022-10-28 17:35 ` [PATCH 07/11] stdlib: Move attribute_hidden definition to function prototype at gmp.h Adhemerval Zanella
2022-10-29 4:37 ` Fangrui Song
2022-10-31 19:55 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 08/11] configure: Use -Wno-ignored-attributes if compiler warns about multiple aliases Adhemerval Zanella
2022-10-29 5:59 ` Fangrui Song
2022-10-31 19:59 ` Adhemerval Zanella Netto
2022-10-31 20:11 ` Fangrui Song
2022-10-28 17:35 ` [PATCH 09/11] alloc_buffer: Apply asm redirection before first use Adhemerval Zanella
2022-10-29 0:32 ` Fangrui Song
2022-10-31 20:01 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 10/11] allocate_once: " Adhemerval Zanella
2022-10-29 0:34 ` Fangrui Song
2022-10-28 17:35 ` [PATCH 11/11] nptl: Fix pthread_create.c build with clang Adhemerval Zanella
2022-10-29 4:51 ` Fangrui Song
2022-10-31 20:03 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f5afa2a-f5ba-cf87-3f81-49661d802f83@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=crrodriguez@opensuse.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).