Re: [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 28/10/22 21:44, Fangrui Song wrote:
> On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote:
>> Clang warns that '__gettextnerrs' set but not used:
>>
>>  intl/plural.c:1034:9: error: variable '__gettextnerrs' set but not used
>>  [-Werror,-Wunused-but-set-variable]
>>      int yynerrs = 0;
>>        ^
>>
>> Since the file is auto-generated, suppress the warning with a compiler
>> flag.
>> ---
>> intl/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/intl/Makefile b/intl/Makefile
>> index 315c75a18f..1c3b2a2273 100644
>> --- a/intl/Makefile
>> +++ b/intl/Makefile
>> @@ -154,7 +154,8 @@ $(objpfx)tst-gettext5.out: $(objpfx)tst-gettext.out
>> $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out
>>
>> CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \
>> -        -D'LOCALE_ALIAS_PATH="$(localedir)"'
>> +        -D'LOCALE_ALIAS_PATH="$(localedir)"' \
>> +        -Wno-unused-but-set-variable
>> BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output
>>
>> $(inst_localedir)/locale.alias: locale.alias $(+force)
>> -- 
>> 2.34.1
>>
> 
> yynerrs is incremented but its value is unused.
> Clang 15 (https://reviews.llvm.org/D122271) -Wunused-but-set-variable
> gives a warning while GCC doesn't.
> -Wunused-but-set-variable is available in GCC 4.6, smaller than the minimum required version 6.2.

I will add this on commit message.

> 
> Reviewed-by: Fangrui Song <maskray@google.com>

Thanks.