From: Fangrui Song <maskray@google.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 04/11] linux: Move hidden_proto before static inline usage on not-cancel.h
Date: Fri, 28 Oct 2022 21:23:15 -0700 [thread overview]
Message-ID: <20221029042315.tpohhuktfyt5yctz@google.com> (raw)
In-Reply-To: <20221028173532.876027-5-adhemerval.zanella@linaro.org>
On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote:
>It is avoid a build failure on clang where it can redeclare function
>attribute after its first use.
can => can't
But, consider using a subject line similar to other "Apply asm redirection before first use" patches?
>---
> sysdeps/unix/sysv/linux/not-cancel.h | 30 ++++++++++++++--------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
>diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h
>index 93615de681..d4f1e0fbde 100644
>--- a/sysdeps/unix/sysv/linux/not-cancel.h
>+++ b/sysdeps/unix/sysv/linux/not-cancel.h
>@@ -52,6 +52,21 @@ __typeof (__write) __write_nocancel;
> /* Uncancelable close. */
> __typeof (__close) __close_nocancel;
>
>+/* Uncancelable fcntl. */
>+__typeof (__fcntl) __fcntl64_nocancel;
>+
>+#if IS_IN (libc) || IS_IN (rtld)
>+hidden_proto (__open_nocancel)
>+hidden_proto (__open64_nocancel)
>+hidden_proto (__openat_nocancel)
>+hidden_proto (__openat64_nocancel)
>+hidden_proto (__read_nocancel)
>+hidden_proto (__pread64_nocancel)
>+hidden_proto (__write_nocancel)
>+hidden_proto (__close_nocancel)
>+hidden_proto (__fcntl64_nocancel)
>+#endif
>+
> /* Non cancellable close syscall that does not also set errno in case of
> failure. */
> static inline void
>@@ -80,19 +95,4 @@ __poll_infinity_nocancel (struct pollfd *fds, nfds_t nfds)
> return INLINE_SYSCALL_CALL (ppoll, fds, nfds, NULL, NULL, 0);
> }
>
>-/* Uncancelable fcntl. */
>-__typeof (__fcntl) __fcntl64_nocancel;
>-
>-#if IS_IN (libc) || IS_IN (rtld)
>-hidden_proto (__open_nocancel)
>-hidden_proto (__open64_nocancel)
>-hidden_proto (__openat_nocancel)
>-hidden_proto (__openat64_nocancel)
>-hidden_proto (__read_nocancel)
>-hidden_proto (__pread64_nocancel)
>-hidden_proto (__write_nocancel)
>-hidden_proto (__close_nocancel)
>-hidden_proto (__fcntl64_nocancel)
>-#endif
>-
> #endif /* NOT_CANCEL_H */
>--
>2.34.1
>
This fixed
In file included from check_fds.c:34:
../sysdeps/unix/sysv/linux/not-cancel.h:94:15: error: cannot apply asm label to function after its first use
hidden_proto (__close_nocancel)
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
./../include/libc-symbols.h:513:19: note: expanded from macro 'hidden_proto'
__hidden_proto (name, , __GI_##name, ##attrs)
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./../include/libc-symbols.h:519:33: note: expanded from macro '__hidden_proto'
extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Reviewed-by: Fangrui Song <maskray@google.com>
next prev parent reply other threads:[~2022-10-29 4:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 17:35 [PATCH 00/11] Initial fixes for clang build support Adhemerval Zanella
2022-10-28 17:35 ` [PATCH 01/11] stdlib/longlong.h: Remove incorrect lvalue to rvalue conversion from asm output constraints Adhemerval Zanella
2022-10-28 21:05 ` Joseph Myers
2022-10-28 21:32 ` Fangrui Song
2022-10-31 18:32 ` Adhemerval Zanella Netto
2022-11-01 13:56 ` Adhemerval Zanella Netto
2022-11-01 14:18 ` Joseph Myers
2022-11-01 17:05 ` Adhemerval Zanella Netto
2022-11-02 15:14 ` Cristian Rodríguez
2022-11-02 17:10 ` Adhemerval Zanella Netto
2022-11-02 19:43 ` Cristian Rodríguez
2022-11-03 12:17 ` Adhemerval Zanella Netto
2022-11-01 17:11 ` Andrew Pinski
2022-11-06 19:30 ` Fangrui Song
2022-11-06 19:32 ` Fangrui Song
2022-11-07 13:39 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 02/11] Disable __USE_EXTERN_INLINES for clang Adhemerval Zanella
2022-10-28 21:06 ` Joseph Myers
2022-10-28 22:02 ` Fangrui Song
2022-10-31 18:33 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 03/11] Rewrite find_cxx_header config configure.ac Adhemerval Zanella
2022-10-29 4:03 ` Fangrui Song
2022-10-31 19:30 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 04/11] linux: Move hidden_proto before static inline usage on not-cancel.h Adhemerval Zanella
2022-10-29 4:23 ` Fangrui Song [this message]
2022-10-31 19:48 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c Adhemerval Zanella
2022-10-29 0:44 ` Fangrui Song
2022-10-31 19:54 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 06/11] Disable use of -fsignaling-nans if compiler does not support it Adhemerval Zanella
2022-10-29 4:19 ` Fangrui Song
2022-10-31 20:01 ` Fangrui Song
2022-10-28 17:35 ` [PATCH 07/11] stdlib: Move attribute_hidden definition to function prototype at gmp.h Adhemerval Zanella
2022-10-29 4:37 ` Fangrui Song
2022-10-31 19:55 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 08/11] configure: Use -Wno-ignored-attributes if compiler warns about multiple aliases Adhemerval Zanella
2022-10-29 5:59 ` Fangrui Song
2022-10-31 19:59 ` Adhemerval Zanella Netto
2022-10-31 20:11 ` Fangrui Song
2022-10-28 17:35 ` [PATCH 09/11] alloc_buffer: Apply asm redirection before first use Adhemerval Zanella
2022-10-29 0:32 ` Fangrui Song
2022-10-31 20:01 ` Adhemerval Zanella Netto
2022-10-28 17:35 ` [PATCH 10/11] allocate_once: " Adhemerval Zanella
2022-10-29 0:34 ` Fangrui Song
2022-10-28 17:35 ` [PATCH 11/11] nptl: Fix pthread_create.c build with clang Adhemerval Zanella
2022-10-29 4:51 ` Fangrui Song
2022-10-31 20:03 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221029042315.tpohhuktfyt5yctz@google.com \
--to=maskray@google.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).