public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>, Florian Weimer <fweimer@redhat.com>
Cc: Richard Biener via Gcc <gcc@gcc.gnu.org>,
	GNU C Library <libc-alpha@sourceware.org>,
	Joseph Myers <joseph@codesourcery.com>,
	libc-coord@lists.openwall.com
Subject: Re: [libc-coord] Add new ABI '__memcmpeq()' to libc
Date: Fri, 17 Sep 2021 10:55:38 -0600	[thread overview]
Message-ID: <455bbaab-5ed3-fa1d-cf51-1b0a644c858d@gmail.com> (raw)
In-Reply-To: <20210917091219.GL304296@tucnak>

On 9/17/21 3:12 AM, Jakub Jelinek via Gcc wrote:
> On Fri, Sep 17, 2021 at 10:08:34AM +0200, Florian Weimer via Gcc wrote:
>>> So the compiler would emit a call to __memcmpeq and at the same time
>>> emit a weak alias of __memcmpeq to memcmp so the program links
>>> when the libc version targeted does not provide __memcmpeq?  Or would
>>> glibc through <string.h> magically communicate the availability of the new ABI
>>> without actually declaring the function?
>>
>> I do not think ELF provides that capability.
>>
>> We can add a declaration to <string.h> to communicate the availability.
>> I think this is how glibc (and other libcs) communicate the availability
>> of non-standard interfaces to GCC.
> 
> Yeah, that is what we've done in the past, e.g. in case of stpcpy.

The stpcpy hack has been a cause of mysterious bugs as discussed
in pr82429.  It means that programs that declare standard functions
without #including <string.h> or use GCC built-ins directly are
enalized by ending up with suboptimal code than those that do
include the header.

It's also a subtlety that not all of us keep in mind when working
on GCC, that can lead to wasted time trying to understand why
an expected optimization isn't working in one test case when it
does work in an apparently equivalent one.

Martin

  reply	other threads:[~2021-09-17 16:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 17:02 Noah Goldstein
2021-09-16 17:55 ` [libc-coord] " Chris Kennelly
2021-09-16 18:31   ` Noah Goldstein
2021-09-16 20:32     ` Chris Kennelly
2021-09-16 20:35       ` Joseph Myers
2021-09-16 20:55         ` enh
2021-09-17  7:43         ` Richard Biener
2021-09-17  8:08           ` Florian Weimer
2021-09-17  8:31             ` Richard Biener
2021-09-17  8:37               ` Florian Weimer
2021-09-17  9:30                 ` Richard Biener
2021-09-17 17:40               ` Noah Goldstein
2021-09-17  9:12             ` Jakub Jelinek
2021-09-17 16:55               ` Martin Sebor [this message]
2021-09-17 14:19           ` Joseph Myers
2021-09-17 14:26             ` Florian Weimer
2021-09-21 19:53               ` Noah Goldstein
2021-09-22 17:46                 ` Christoph Müllner
2021-09-22 18:15                   ` Noah Goldstein
2021-09-16 21:27 ` James Y Knight
2021-09-16 21:42   ` Joseph Myers
2021-09-16 21:50     ` enh
2021-09-16 21:59       ` Noah Goldstein
2021-09-16 22:17       ` Chris Kennelly
2021-09-16 22:36         ` Joseph Myers
2021-09-16 23:24         ` Noah Goldstein
2021-09-18  1:36       ` James Y Knight
2021-10-26 22:47 ` Noah Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455bbaab-5ed3-fa1d-cf51-1b0a644c858d@gmail.com \
    --to=msebor@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=gcc@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-coord@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).