* [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398]
@ 2022-01-26 20:51 H.J. Lu
2022-01-27 4:54 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2022-01-26 20:51 UTC (permalink / raw)
To: libc-alpha
HLE is disabled on blacklisted CPUs. Use CHECK_FEATURE_PRESENT, instead
of CHECK_FEATURE_ACTIVE, to check HLE.
---
sysdeps/x86/tst-cpu-features-supports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
index 46b2c7bf83..9f10f02954 100644
--- a/sysdeps/x86/tst-cpu-features-supports.c
+++ b/sysdeps/x86/tst-cpu-features-supports.c
@@ -130,7 +130,7 @@ do_test (int argc, char **argv)
fails += CHECK_FEATURE_ACTIVE (gfni, GFNI);
#endif
#if __GNUC_PREREQ (11, 0)
- fails += CHECK_FEATURE_ACTIVE (hle, HLE);
+ fails += CHECK_FEATURE_PRESENT (hle, HLE);
fails += CHECK_FEATURE_PRESENT (ibt, IBT);
fails += CHECK_FEATURE_ACTIVE (lahf_lm, LAHF64_SAHF64);
fails += CHECK_FEATURE_PRESENT (lm, LM);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398]
2022-01-26 20:51 [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398] H.J. Lu
@ 2022-01-27 4:54 ` Carlos O'Donell
2022-02-01 13:43 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Carlos O'Donell @ 2022-01-27 4:54 UTC (permalink / raw)
To: H.J. Lu, libc-alpha
On 1/26/22 15:51, H.J. Lu wrote:
> HLE is disabled on blacklisted CPUs. Use CHECK_FEATURE_PRESENT, instead
> of CHECK_FEATURE_ACTIVE, to check HLE.
OK for glibc 2.35. Fixes the issue on my T590 with the resume issues.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/x86/tst-cpu-features-supports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
> index 46b2c7bf83..9f10f02954 100644
> --- a/sysdeps/x86/tst-cpu-features-supports.c
> +++ b/sysdeps/x86/tst-cpu-features-supports.c
> @@ -130,7 +130,7 @@ do_test (int argc, char **argv)
> fails += CHECK_FEATURE_ACTIVE (gfni, GFNI);
> #endif
> #if __GNUC_PREREQ (11, 0)
> - fails += CHECK_FEATURE_ACTIVE (hle, HLE);
> + fails += CHECK_FEATURE_PRESENT (hle, HLE);
> fails += CHECK_FEATURE_PRESENT (ibt, IBT);
> fails += CHECK_FEATURE_ACTIVE (lahf_lm, LAHF64_SAHF64);
> fails += CHECK_FEATURE_PRESENT (lm, LM);
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398]
2022-01-27 4:54 ` Carlos O'Donell
@ 2022-02-01 13:43 ` H.J. Lu
0 siblings, 0 replies; 3+ messages in thread
From: H.J. Lu @ 2022-02-01 13:43 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: GNU C Library
On Wed, Jan 26, 2022 at 8:54 PM Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 1/26/22 15:51, H.J. Lu wrote:
> > HLE is disabled on blacklisted CPUs. Use CHECK_FEATURE_PRESENT, instead
> > of CHECK_FEATURE_ACTIVE, to check HLE.
>
> OK for glibc 2.35. Fixes the issue on my T590 with the resume issues.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> Tested-by: Carlos O'Donell <carlos@redhat.com>
>
> > ---
> > sysdeps/x86/tst-cpu-features-supports.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c
> > index 46b2c7bf83..9f10f02954 100644
> > --- a/sysdeps/x86/tst-cpu-features-supports.c
> > +++ b/sysdeps/x86/tst-cpu-features-supports.c
> > @@ -130,7 +130,7 @@ do_test (int argc, char **argv)
> > fails += CHECK_FEATURE_ACTIVE (gfni, GFNI);
> > #endif
> > #if __GNUC_PREREQ (11, 0)
> > - fails += CHECK_FEATURE_ACTIVE (hle, HLE);
> > + fails += CHECK_FEATURE_PRESENT (hle, HLE);
> > fails += CHECK_FEATURE_PRESENT (ibt, IBT);
> > fails += CHECK_FEATURE_ACTIVE (lahf_lm, LAHF64_SAHF64);
> > fails += CHECK_FEATURE_PRESENT (lm, LM);
>
>
> --
> Cheers,
> Carlos.
>
I am backporting this to release branches.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-01 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 20:51 [PATCH] x86: Use CHECK_FEATURE_PRESENT to check HLE [BZ #27398] H.J. Lu
2022-01-27 4:54 ` Carlos O'Donell
2022-02-01 13:43 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).