Re: [PATCH 1/2] elf: Remove glibc.rtld.dynamic_sort tunable

[Siddhesh Poyarekar <siddhesh@gotplt.org>]

On 2023-03-22 14:46, Adhemerval Zanella Netto wrote:
>> OK, I'll stick to reviewing the --enable-tunables patch then, assuming that it can go in independently of this one.  I feel much less comfortable acking this one since I haven't been closely involved in sorting algorithm selection.  I get the sense that maybe it makes sense to wait a couple more releases before removing the old sort algorithm but that's not based on any specific knowledge, just an instinct.
> 
> Well, without tunables the old algorithm can not be selected.  So the second
> part does depend of this.

I don't get it, wouldn't the old algorithm get selected using the 
glibc.rtld.dynamic_sort tunable?  How would the ability to disable 
tunables affect that?

> The old algorithm was kept mainly to provide some fallback compatibility to
> binaries that does not work correctly with newer one; but the default one
> is already in 3 release, it is faster, and so far I have not heard of any
> drawnback.

It may take 2-3 years for some of the slower moving application devs to 
get to use the current glibc, hence my spitball about another year or 
so.  But don't mind my opinion on this, hopefully others can chime in on it.

Thanks,
Sid