Re: [PATCH 1/2] elf: Remove glibc.rtld.dynamic_sort tunable

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 22/03/23 15:40, Siddhesh Poyarekar wrote:
> On 2023-03-22 13:51, Adhemerval Zanella Netto wrote:
>>
>>
>> On 22/03/23 14:08, Siddhesh Poyarekar wrote:
>>> On 2023-03-13 15:06, Adhemerval Zanella wrote:
>>>> And make the DFS algorithm (added on 2.35) the de-facto implementation.
>>>
>>> Isn't this orthogonal to the proposal to remove --enable-tunables?
>>
>> Yes, the DFS is already the default one.  I meant that now there is no way to
>> select the one algorithm.  Maybe use the commit messagE:
>>
>>    And make the old sort algorithm no longer available.
> 
> OK, I'll stick to reviewing the --enable-tunables patch then, assuming that it can go in independently of this one.  I feel much less comfortable acking this one since I haven't been closely involved in sorting algorithm selection.  I get the sense that maybe it makes sense to wait a couple more releases before removing the old sort algorithm but that's not based on any specific knowledge, just an instinct.

Well, without tunables the old algorithm can not be selected.  So the second
part does depend of this.

The old algorithm was kept mainly to provide some fallback compatibility to
binaries that does not work correctly with newer one; but the default one
is already in 3 release, it is faster, and so far I have not heard of any
drawnback.