public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Remove MAP_VARIABLE from hppa bits/mman.h
@ 2023-05-17 20:38 Joseph Myers
  2023-05-25 21:34 ` Ping " Joseph Myers
  2023-06-03  2:02 ` Carlos O'Donell
  0 siblings, 2 replies; 4+ messages in thread
From: Joseph Myers @ 2023-05-17 20:38 UTC (permalink / raw)
  To: libc-alpha

As suggested in
<https://sourceware.org/pipermail/libc-alpha/2023-February/145890.html>,
remove the MAP_VARIABLE define from the hppa bits/mman.h, for
consistency with Linux 6.2 which removed the define there.

Tested with build-many-glibcs.py for hppa-linux-gnu.

diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
index f5a69693af..651b7dcb72 100644
--- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h
+++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
@@ -24,7 +24,6 @@
 
 /* Other flags.  */
 #define __MAP_ANONYMOUS	0x10		/* Don't use a file */
-#define MAP_VARIABLE	0
 
 /* These are Linux-specific.  */
 #define MAP_DENYWRITE	0x0800		/* ETXTBSY */

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Ping Re: Remove MAP_VARIABLE from hppa bits/mman.h
  2023-05-17 20:38 Remove MAP_VARIABLE from hppa bits/mman.h Joseph Myers
@ 2023-05-25 21:34 ` Joseph Myers
  2023-06-02 22:11   ` Ping^2 " Joseph Myers
  2023-06-03  2:02 ` Carlos O'Donell
  1 sibling, 1 reply; 4+ messages in thread
From: Joseph Myers @ 2023-05-25 21:34 UTC (permalink / raw)
  To: libc-alpha

Ping.  This patch 
<https://sourceware.org/pipermail/libc-alpha/2023-May/148220.html> is 
pending review.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Ping^2 Re: Remove MAP_VARIABLE from hppa bits/mman.h
  2023-05-25 21:34 ` Ping " Joseph Myers
@ 2023-06-02 22:11   ` Joseph Myers
  0 siblings, 0 replies; 4+ messages in thread
From: Joseph Myers @ 2023-06-02 22:11 UTC (permalink / raw)
  To: libc-alpha

Ping^2.  This patch 
<https://sourceware.org/pipermail/libc-alpha/2023-May/148220.html> is 
still pending review.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Remove MAP_VARIABLE from hppa bits/mman.h
  2023-05-17 20:38 Remove MAP_VARIABLE from hppa bits/mman.h Joseph Myers
  2023-05-25 21:34 ` Ping " Joseph Myers
@ 2023-06-03  2:02 ` Carlos O'Donell
  1 sibling, 0 replies; 4+ messages in thread
From: Carlos O'Donell @ 2023-06-03  2:02 UTC (permalink / raw)
  To: Joseph Myers, libc-alpha

On 5/17/23 16:38, Joseph Myers wrote:
> As suggested in
> <https://sourceware.org/pipermail/libc-alpha/2023-February/145890.html>,
> remove the MAP_VARIABLE define from the hppa bits/mman.h, for
> consistency with Linux 6.2 which removed the define there.
> 
> Tested with build-many-glibcs.py for hppa-linux-gnu.
> 
> diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> index f5a69693af..651b7dcb72 100644
> --- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> +++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> @@ -24,7 +24,6 @@
>  
>  /* Other flags.  */
>  #define __MAP_ANONYMOUS	0x10		/* Don't use a file */
> -#define MAP_VARIABLE	0
>  
>  /* These are Linux-specific.  */
>  #define MAP_DENYWRITE	0x0800		/* ETXTBSY */
> 

LGTM.

Reviewed Linux at commit 933174ae28ba72ab8de5b35cb7c98fc211235096 (6.4.0-rc3)
and there is no more references to MAP_VARIABLE.

The references are removed as of 71bdea6f798b425bc0003780b13e3fdecb16a010 and
are no longer in the UAPI mman.h headers.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-03  2:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-17 20:38 Remove MAP_VARIABLE from hppa bits/mman.h Joseph Myers
2023-05-25 21:34 ` Ping " Joseph Myers
2023-06-02 22:11   ` Ping^2 " Joseph Myers
2023-06-03  2:02 ` Carlos O'Donell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).