From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: V3 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203]
Date: Thu, 01 Oct 2020 10:46:10 +0200 [thread overview]
Message-ID: <87362yl4fh.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOpJWfY8rrNYycusxdnfEXe70ehXK2EJ1NCpNLPks=nEXw@mail.gmail.com> (H. J. Lu's message of "Tue, 29 Sep 2020 04:44:50 -0700")
* H. J. Lu:
> diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
> index dadec5d58f..65ab29123d 100644
> --- a/sysdeps/x86/cacheinfo.c
> +++ b/sysdeps/x86/cacheinfo.c
> @@ -16,7 +16,9 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> -#if IS_IN (libc)
> +/* NB: In libc.a, this file is included in libc-static.c. In libc.so,
> + this file is standalone. */
> +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEATURES_H)
libc-static.c should be libc-start.c, I believe. The “defined
_PRIVATE_CPU_FEATURES_H” part seems rather indirect. What exactly are
you trying to accomplish here?
It looks to me as if this file should included in libc.so, but not
pulled into ld.so via the rebuild, so maybe you can add an empty
sysdeps/x86/rtld-cacheinfo.c file instead?
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2020-10-01 8:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:07 V2 [PATCH 0/4] ld.so: Add --list-tunables to print tunable values H.J. Lu
2020-09-18 16:07 ` [PATCH 1/4] x86: Initialize CPU info via IFUNC relocation [BZ 26203] H.J. Lu
2020-09-28 13:08 ` Florian Weimer
2020-09-28 13:48 ` H.J. Lu
2020-09-28 14:05 ` Florian Weimer
2020-09-28 14:20 ` H.J. Lu
2020-09-28 14:22 ` Florian Weimer
2020-09-28 14:39 ` H.J. Lu
2020-09-28 14:47 ` Florian Weimer
2020-09-28 17:54 ` V3 [PATCH] " H.J. Lu
2020-09-29 7:53 ` Florian Weimer
2020-09-29 11:44 ` H.J. Lu
2020-10-01 8:46 ` Florian Weimer [this message]
2020-10-01 19:50 ` V4 " H.J. Lu
2020-10-08 13:22 ` PING: " H.J. Lu
2020-10-15 12:53 ` PING^2: " H.J. Lu
2022-05-02 13:59 ` Sunil Pandey
2022-05-03 18:51 ` Sunil Pandey
2020-09-18 16:07 ` [PATCH 2/4] Set tunable value as well as min/max values H.J. Lu
2020-09-28 13:35 ` Florian Weimer
2020-09-28 13:53 ` H.J. Lu
2020-09-28 14:03 ` Florian Weimer
2020-09-28 17:30 ` Siddhesh Poyarekar
2020-09-29 4:00 ` V3 [PATCH] " H.J. Lu
2020-09-29 4:45 ` Siddhesh Poyarekar
2020-09-29 4:47 ` Siddhesh Poyarekar
2020-09-29 12:30 ` V4 " H.J. Lu
2020-09-29 13:50 ` Siddhesh Poyarekar
2020-09-29 14:54 ` V5 " H.J. Lu
2020-09-29 15:58 ` Siddhesh Poyarekar
2020-09-18 16:07 ` [PATCH 3/4] x86: Move x86 processor cache info to cpu_features H.J. Lu
2020-09-18 16:07 ` [PATCH 4/4] ld.so: Add --list-tunables to print tunable values H.J. Lu
2020-09-21 8:25 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87362yl4fh.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).