From: Florian Weimer <fweimer@redhat.com>
To: Jonathan Wakely via Libc-alpha <libc-alpha@sourceware.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [PATCH v2] Suppress -Wcast-qual warnings in bsearch
Date: Thu, 30 Sep 2021 12:43:23 +0200 [thread overview]
Message-ID: <87czoq4a44.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CACb0b4mXELY54dcjrfaFjCcLJz56jOcaQH1kgVzFHFAp_7CcuQ@mail.gmail.com> (Jonathan Wakely via Libc-alpha's message of "Thu, 30 Sep 2021 10:22:20 +0100")
* Jonathan Wakely via Libc-alpha:
> diff --git a/bits/stdlib-bsearch.h b/bits/stdlib-bsearch.h
> index 4132dc6af0..d688ed2e15 100644
> --- a/bits/stdlib-bsearch.h
> +++ b/bits/stdlib-bsearch.h
> @@ -29,14 +29,21 @@ bsearch (const void *__key, const void *__base, size_t __nmemb, size_t __size,
> while (__l < __u)
> {
> __idx = (__l + __u) / 2;
> - __p = (void *) (((const char *) __base) + (__idx * __size));
> + __p = (const void *) (((const char *) __base) + (__idx * __size));
> __comparison = (*__compar) (__key, __p);
> if (__comparison < 0)
> __u = __idx;
> else if (__comparison > 0)
> __l = __idx + 1;
> else
> +#if __GNUC_PREREQ(4, 6)
> +# pragma GCC diagnostic push
> +# pragma GCC diagnostic ignored "-Wcast-qual"
> +#endif
> return (void *) __p;
> +#if __GNUC_PREREQ(4, 6)
> +# pragma GCC diagnostic pop
> +#endif
> }
>
> return NULL;
Patch looks okay, thanks.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Florian
next prev parent reply other threads:[~2021-09-30 10:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:14 [PATCH] " Jonathan Wakely
2021-05-19 15:37 ` Joseph Myers
2021-05-19 15:50 ` Jonathan Wakely
2021-06-01 10:09 ` [PATCH v3] " Jonathan Wakely
2021-09-30 9:22 ` [PATCH v2] " Jonathan Wakely
2021-09-30 10:43 ` Florian Weimer [this message]
2021-09-30 14:49 ` Adhemerval Zanella
2021-09-30 15:07 ` Joseph Myers
2021-09-30 15:19 ` Adhemerval Zanella
2021-09-30 15:30 ` Andreas Schwab
2021-09-30 16:41 ` Florian Weimer
2021-09-30 16:42 ` Joseph Myers
2021-09-30 16:52 ` Jonathan Wakely
2021-09-30 17:54 ` H.J. Lu
2021-09-30 18:04 ` Florian Weimer
2021-09-30 18:09 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czoq4a44.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=jwakely@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).