From: Jonathan Wakely <jwakely@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: [PATCH v2] Suppress -Wcast-qual warnings in bsearch
Date: Thu, 30 Sep 2021 10:22:20 +0100 [thread overview]
Message-ID: <CACb0b4mXELY54dcjrfaFjCcLJz56jOcaQH1kgVzFHFAp_7CcuQ@mail.gmail.com> (raw)
In-Reply-To: <YKUzzZwNF3YajJaX@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
Ping for patch originally sent in
https://sourceware.org/pipermail/libc-alpha/2021-May/126572.html
The patch still applies cleanly to current master.
On Wed, 19 May 2021 at 16:50, Jonathan Wakely wrote:
>
> On 19/05/21 15:37 +0000, Joseph Myers wrote:
> >On Wed, 19 May 2021, Jonathan Wakely via Libc-alpha wrote:
> >
> >> +#pragma GCC diagnostic push
> >> +#pragma GCC diagnostic ignored "-Wcast-qual"
> >> return (void *) __p;
> >> +#pragma GCC diagnostic pop
> >
> >I think such pragma uses in installed headers should be conditional on
> >__GNUC_PREREQ (4, 6) (either directly or via conditionally defining a
> >macro in sys/cdefs.h).
>
> Good point.
>
> I spent about two minutes trying to do something with _Pragma in
> sys/cdefs.h to allow:
>
> __GLIBC_IGNORE_WARNING("-Wcast-qual")
> return (void *) __p;
> __GLIBC_UNIGNORE_WARNING
>
> but didn't get it working, so here's a patch that just tests
> __GNUC_PREREQ directly.
>
>
[-- Attachment #2: bsearch.patch --]
[-- Type: application/x-patch, Size: 1316 bytes --]
next prev parent reply other threads:[~2021-09-30 9:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:14 [PATCH] " Jonathan Wakely
2021-05-19 15:37 ` Joseph Myers
2021-05-19 15:50 ` Jonathan Wakely
2021-06-01 10:09 ` [PATCH v3] " Jonathan Wakely
2021-09-30 9:22 ` Jonathan Wakely [this message]
2021-09-30 10:43 ` [PATCH v2] " Florian Weimer
2021-09-30 14:49 ` Adhemerval Zanella
2021-09-30 15:07 ` Joseph Myers
2021-09-30 15:19 ` Adhemerval Zanella
2021-09-30 15:30 ` Andreas Schwab
2021-09-30 16:41 ` Florian Weimer
2021-09-30 16:42 ` Joseph Myers
2021-09-30 16:52 ` Jonathan Wakely
2021-09-30 17:54 ` H.J. Lu
2021-09-30 18:04 ` Florian Weimer
2021-09-30 18:09 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4mXELY54dcjrfaFjCcLJz56jOcaQH1kgVzFHFAp_7CcuQ@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).