public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Suppress -Wcast-qual warnings in bsearch
Date: Wed, 19 May 2021 15:37:27 +0000	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2105191535500.14970@digraph.polyomino.org.uk> (raw)
In-Reply-To: <YKUdWuzFbiAnWx+Y@redhat.com>

On Wed, 19 May 2021, Jonathan Wakely via Libc-alpha wrote:

> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wcast-qual"
>  	return (void *) __p;
> +#pragma GCC diagnostic pop

I think such pragma uses in installed headers should be conditional on 
__GNUC_PREREQ (4, 6) (either directly or via conditionally defining a 
macro in sys/cdefs.h).

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2021-05-19 15:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 14:14 Jonathan Wakely
2021-05-19 15:37 ` Joseph Myers [this message]
2021-05-19 15:50   ` Jonathan Wakely
2021-06-01 10:09     ` [PATCH v3] " Jonathan Wakely
2021-09-30  9:22     ` [PATCH v2] " Jonathan Wakely
2021-09-30 10:43       ` Florian Weimer
2021-09-30 14:49         ` Adhemerval Zanella
2021-09-30 15:07           ` Joseph Myers
2021-09-30 15:19             ` Adhemerval Zanella
2021-09-30 15:30               ` Andreas Schwab
2021-09-30 16:41               ` Florian Weimer
2021-09-30 16:42               ` Joseph Myers
2021-09-30 16:52           ` Jonathan Wakely
2021-09-30 17:54           ` H.J. Lu
2021-09-30 18:04             ` Florian Weimer
2021-09-30 18:09               ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2105191535500.14970@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=jwakely@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).