From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>, Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [PATCH v2] Suppress -Wcast-qual warnings in bsearch
Date: Thu, 30 Sep 2021 15:07:57 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2109301506230.886109@digraph.polyomino.org.uk> (raw)
In-Reply-To: <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org>
On Thu, 30 Sep 2021, Adhemerval Zanella via Libc-alpha wrote:
> >> else
> >> +#if __GNUC_PREREQ(4, 6)
> >> +# pragma GCC diagnostic push
> >> +# pragma GCC diagnostic ignored "-Wcast-qual"
> >> +#endif
> >> return (void *) __p;
> >> +#if __GNUC_PREREQ(4, 6)
> >> +# pragma GCC diagnostic pop
> >> +#endif
> >> }
I think braces may need adding around those pragmas to avoid a pragma
being considered the body of the else in some cases.
> For instance some math tests shows ulps failures that does not
> make much sense:
libm-test-support.c does use bsearch (in order to look up ulps by name in
a table).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-09-30 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:14 [PATCH] " Jonathan Wakely
2021-05-19 15:37 ` Joseph Myers
2021-05-19 15:50 ` Jonathan Wakely
2021-06-01 10:09 ` [PATCH v3] " Jonathan Wakely
2021-09-30 9:22 ` [PATCH v2] " Jonathan Wakely
2021-09-30 10:43 ` Florian Weimer
2021-09-30 14:49 ` Adhemerval Zanella
2021-09-30 15:07 ` Joseph Myers [this message]
2021-09-30 15:19 ` Adhemerval Zanella
2021-09-30 15:30 ` Andreas Schwab
2021-09-30 16:41 ` Florian Weimer
2021-09-30 16:42 ` Joseph Myers
2021-09-30 16:52 ` Jonathan Wakely
2021-09-30 17:54 ` H.J. Lu
2021-09-30 18:04 ` Florian Weimer
2021-09-30 18:09 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2109301506230.886109@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=jwakely@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).