public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
	 Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	"H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v2] x86-64: Optimize bzero
Date: Fri, 25 Feb 2022 11:35:30 -0600	[thread overview]
Message-ID: <CAFUsyfKFCAv2kmJ4n-MfU5hMeBNP1sEfxQTx3SLU0tVPQP56Ag@mail.gmail.com> (raw)
In-Reply-To: <AS8PR08MB6534AAD15E8948D859FE1F5D833E9@AS8PR08MB6534.eurprd08.prod.outlook.com>

On Fri, Feb 25, 2022 at 7:51 AM Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>
> Hi Noah,
>
> > What method are you using for getting total function call overhead?
> >
> > Using `perf record` + `pref report` and see a fair amount of variance but much
> > higher memset overheader (counting `_*unaligned_erms` and `*_unaligned`)
> > in `cc1` and `as`.
> >
> > From average of 3 runs compiling file with 1/10/100/1000 functions I get:
>
> For accurate profiles you need to run for longer and increase the sampling rate.

Ran with `-F max`. Would say error bar is ~.5% still (which is [12, 25]% of the
overall overhead so not insignificant.

> The 1000 function version takes less than a second to compile, which is why I
> went for 10000 functions at 20000 samples per second.
>
> I used LD_PRELOAD to use the latest version of __memset_exex_unaligned_erms.
> You can also trivially collect statistics of memset this way. Eg. in this benchmark
> 75% of memset is <= 32 bytes and average memset size 44 bytes, so it has a far
> higher percentage of really small memsets compared to normal compilation.

Does that mean you manually inserted timers to get total function call overhead?

But I see, was just curious if there was some simple audit more
precise than `perf record`
that didn't require building custom infrastructure.

>
> Cheers,
> Wilco

  reply	other threads:[~2022-02-25 17:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 13:38 Wilco Dijkstra
2022-02-23  8:12 ` Noah Goldstein
2022-02-23 12:09   ` Adhemerval Zanella
2022-02-24 13:16   ` Wilco Dijkstra
2022-02-24 15:48     ` H.J. Lu
2022-02-24 22:58     ` Noah Goldstein
2022-02-24 23:21       ` Noah Goldstein
2022-02-25 17:37         ` Noah Goldstein
2022-02-25 13:51       ` Wilco Dijkstra
2022-02-25 17:35         ` Noah Goldstein [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-02-08 22:43 H.J. Lu
2022-02-08 23:56 ` Noah Goldstein
2022-02-09 11:41 ` Adhemerval Zanella
2022-02-09 22:14   ` Noah Goldstein
2022-02-10 12:35     ` Adhemerval Zanella
2022-02-10 13:01       ` Wilco Dijkstra
2022-02-10 13:10         ` Adhemerval Zanella
2022-02-10 13:16           ` Adhemerval Zanella
2022-02-10 13:17           ` Wilco Dijkstra
2022-02-10 13:22             ` Adhemerval Zanella
2022-02-10 17:50               ` Alejandro Colomar (man-pages)
2022-02-10 19:19                 ` Wilco Dijkstra
2022-02-10 20:27                   ` Alejandro Colomar (man-pages)
2022-02-10 20:42                     ` Adhemerval Zanella
2022-02-10 21:07                       ` Patrick McGehearty
2022-02-11 13:01                         ` Adhemerval Zanella
2022-02-12 23:46                           ` Noah Goldstein
2022-02-14 12:07                             ` Adhemerval Zanella
2022-02-14 12:41                               ` Noah Goldstein
2022-02-14 14:07                                 ` Adhemerval Zanella
2022-02-14 15:03                                   ` H.J. Lu
2022-05-04  6:35                                     ` Sunil Pandey
2022-05-04 12:52                                       ` Adhemerval Zanella
2022-05-04 14:50                                         ` H.J. Lu
2022-05-04 14:54                                           ` Adhemerval Zanella
2022-02-10 22:00                       ` Alejandro Colomar (man-pages)
2022-02-10 19:42                 ` Adhemerval Zanella
2022-02-10 18:28         ` Noah Goldstein
2022-02-10 18:35         ` Noah Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFUsyfKFCAv2kmJ4n-MfU5hMeBNP1sEfxQTx3SLU0tVPQP56Ag@mail.gmail.com \
    --to=goldstein.w.n@gmail.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).