* [PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c
@ 2022-02-05 9:10 Noah Goldstein
2022-02-05 17:29 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: Noah Goldstein @ 2022-02-05 9:10 UTC (permalink / raw)
To: libc-alpha
One buf allocation is sufficient. Calling `alloc_bufs' in the loop
just adds unnecessary syscall overhead.
---
benchtests/bench-memset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
index beba3fbe46..e1e2d5f176 100644
--- a/benchtests/bench-memset.c
+++ b/benchtests/bench-memset.c
@@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
FOR_EACH_IMPL (impl, 0)
{
do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
- alloc_bufs ();
}
json_array_end (json_ctx);
@@ -88,8 +87,9 @@ test_main (void)
size_t i;
int c = 0;
- test_init ();
+ test_init ();
+ alloc_bufs ();
json_init (&json_ctx, 0, stdout);
json_document_begin (&json_ctx);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c
2022-02-05 9:10 [PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c Noah Goldstein
@ 2022-02-05 17:29 ` H.J. Lu
2022-02-05 22:58 ` Noah Goldstein
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2022-02-05 17:29 UTC (permalink / raw)
To: Noah Goldstein; +Cc: GNU C Library, Carlos O'Donell
On Sat, Feb 5, 2022 at 1:10 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> One buf allocation is sufficient. Calling `alloc_bufs' in the loop
> just adds unnecessary syscall overhead.
> ---
> benchtests/bench-memset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> index beba3fbe46..e1e2d5f176 100644
> --- a/benchtests/bench-memset.c
> +++ b/benchtests/bench-memset.c
> @@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
> FOR_EACH_IMPL (impl, 0)
> {
> do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
> - alloc_bufs ();
> }
>
> json_array_end (json_ctx);
> @@ -88,8 +87,9 @@ test_main (void)
> size_t i;
> int c = 0;
>
> - test_init ();
>
> + test_init ();
> + alloc_bufs ();
> json_init (&json_ctx, 0, stdout);
>
> json_document_begin (&json_ctx);
> --
> 2.25.1
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c
2022-02-05 17:29 ` H.J. Lu
@ 2022-02-05 22:58 ` Noah Goldstein
0 siblings, 0 replies; 3+ messages in thread
From: Noah Goldstein @ 2022-02-05 22:58 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library, Carlos O'Donell
On Sat, Feb 5, 2022 at 11:29 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Feb 5, 2022 at 1:10 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > One buf allocation is sufficient. Calling `alloc_bufs' in the loop
> > just adds unnecessary syscall overhead.
> > ---
> > benchtests/bench-memset.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
> > index beba3fbe46..e1e2d5f176 100644
> > --- a/benchtests/bench-memset.c
> > +++ b/benchtests/bench-memset.c
> > @@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
> > FOR_EACH_IMPL (impl, 0)
> > {
> > do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
> > - alloc_bufs ();
> > }
> >
> > json_array_end (json_ctx);
> > @@ -88,8 +87,9 @@ test_main (void)
> > size_t i;
> > int c = 0;
> >
> > - test_init ();
> >
> > + test_init ();
> > + alloc_bufs ();
> > json_init (&json_ctx, 0, stdout);
> >
> > json_document_begin (&json_ctx);
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
Thanks pushed.
>
> --
> H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-05 22:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 9:10 [PATCH v1] Benchtests: move 'alloc_bufs' from loop in bench-memset.c Noah Goldstein
2022-02-05 17:29 ` H.J. Lu
2022-02-05 22:58 ` Noah Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).