* [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S
@ 2023-06-01 3:43 H.J. Lu
2023-06-01 5:41 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2023-06-01 3:43 UTC (permalink / raw)
To: libc-alpha; +Cc: Noah Goldstein, Sunil K Pandey
Include x86-evex256-vecs.h by default to use YMM registers in
memcmpeq-evex.S.
---
sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
index 3666f649cd..7eefff77f1 100644
--- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
+++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
@@ -42,7 +42,7 @@
# endif
# ifndef VEC_SIZE
-# include "x86-evex512-vecs.h"
+# include "x86-evex256-vecs.h"
# endif
# include "reg-macros.h"
--
2.40.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S
2023-06-01 3:43 [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S H.J. Lu
@ 2023-06-01 5:41 ` Florian Weimer
2023-06-01 15:44 ` Noah Goldstein
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2023-06-01 5:41 UTC (permalink / raw)
To: H.J. Lu via Libc-alpha; +Cc: H.J. Lu, Noah Goldstein, Sunil K Pandey
* H. J. Lu via Libc-alpha:
> Include x86-evex256-vecs.h by default to use YMM registers in
> memcmpeq-evex.S.
> ---
> sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> index 3666f649cd..7eefff77f1 100644
> --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> @@ -42,7 +42,7 @@
> # endif
>
> # ifndef VEC_SIZE
> -# include "x86-evex512-vecs.h"
> +# include "x86-evex256-vecs.h"
> # endif
> # include "reg-macros.h"
It would be nice if the commit message could describe the why, not just
the what. 8-)
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S
2023-06-01 5:41 ` Florian Weimer
@ 2023-06-01 15:44 ` Noah Goldstein
2023-06-01 15:54 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Noah Goldstein @ 2023-06-01 15:44 UTC (permalink / raw)
To: Florian Weimer; +Cc: H.J. Lu via Libc-alpha, H.J. Lu, Sunil K Pandey
On Thu, Jun 1, 2023 at 12:41 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > Include x86-evex256-vecs.h by default to use YMM registers in
> > memcmpeq-evex.S.
Should we create an evex512 impl?
> > ---
> > sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > index 3666f649cd..7eefff77f1 100644
> > --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > @@ -42,7 +42,7 @@
> > # endif
> >
> > # ifndef VEC_SIZE
> > -# include "x86-evex512-vecs.h"
> > +# include "x86-evex256-vecs.h"
> > # endif
> > # include "reg-macros.h"
>
> It would be nice if the commit message could describe the why, not just
> the what. 8-)
>
We use -evex.S postfix for 256-bit evex. This was mistakenly implemented as
evex512.
> Thanks,
> Florian
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S
2023-06-01 15:44 ` Noah Goldstein
@ 2023-06-01 15:54 ` H.J. Lu
0 siblings, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2023-06-01 15:54 UTC (permalink / raw)
To: Noah Goldstein; +Cc: Florian Weimer, H.J. Lu via Libc-alpha, Sunil K Pandey
On Thu, Jun 1, 2023 at 8:44 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> On Thu, Jun 1, 2023 at 12:41 AM Florian Weimer <fweimer@redhat.com> wrote:
> >
> > * H. J. Lu via Libc-alpha:
> >
> > > Include x86-evex256-vecs.h by default to use YMM registers in
> > > memcmpeq-evex.S.
>
> Should we create an evex512 impl?
YMM is good enough for now. There is no need for ZMM.
> > > ---
> > > sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > > index 3666f649cd..7eefff77f1 100644
> > > --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > > +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> > > @@ -42,7 +42,7 @@
> > > # endif
> > >
> > > # ifndef VEC_SIZE
> > > -# include "x86-evex512-vecs.h"
> > > +# include "x86-evex256-vecs.h"
> > > # endif
> > > # include "reg-macros.h"
> >
> > It would be nice if the commit message could describe the why, not just
> > the what. 8-)
> >
>
> We use -evex.S postfix for 256-bit evex. This was mistakenly implemented as
> evex512.
>
>
> > Thanks,
> > Florian
> >
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-01 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 3:43 [PATCH] x86-64: Use YMM registers in memcmpeq-evex.S H.J. Lu
2023-06-01 5:41 ` Florian Weimer
2023-06-01 15:44 ` Noah Goldstein
2023-06-01 15:54 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).