* tst-dso-ordering* failing on aarch64 with --enable-static-pie
@ 2021-11-16 13:47 Siddhesh Poyarekar
2021-11-16 13:49 ` Adhemerval Zanella
0 siblings, 1 reply; 5+ messages in thread
From: Siddhesh Poyarekar @ 2021-11-16 13:47 UTC (permalink / raw)
To: libc-alpha, Szabolcs Nagy
Hello,
It looks like ordering related tests are failing on aarch64 with glibc
built with --enable-static-pie. Anyone wants to take a look at this?
The full build log is here:
https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log
Thanks,
Siddhesh
=====FAIL: elf/tst-bz15311.out=====
FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
=====FAIL: elf/tst-bz15311.test-result=====
FAIL: elf/tst-bz15311
original exit status 1
=====FAIL: elf/tst-dso-ordering1.out=====
FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1)
execution test
FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2)
execution test
=====FAIL: elf/tst-dso-ordering1.test-result=====
FAIL: elf/tst-dso-ordering1
original exit status 1
=====FAIL: elf/tst-dso-ordering10.out=====
FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1)
execution test
FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2)
execution test
=====FAIL: elf/tst-dso-ordering10.test-result=====
FAIL: elf/tst-dso-ordering10
original exit status 1
=====FAIL: elf/tst-dso-ordering2.out=====
FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1)
execution test
FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2)
execution test
=====FAIL: elf/tst-dso-ordering2.test-result=====
FAIL: elf/tst-dso-ordering2
original exit status 1
=====FAIL: elf/tst-dso-ordering3.out=====
FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1)
execution test
FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2)
execution test
=====FAIL: elf/tst-dso-ordering3.test-result=====
FAIL: elf/tst-dso-ordering3
original exit status 1
=====FAIL: elf/tst-dso-ordering4.out=====
FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1)
execution test
FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2)
execution test
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: tst-dso-ordering* failing on aarch64 with --enable-static-pie
2021-11-16 13:47 tst-dso-ordering* failing on aarch64 with --enable-static-pie Siddhesh Poyarekar
@ 2021-11-16 13:49 ` Adhemerval Zanella
2021-11-16 14:11 ` H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Adhemerval Zanella @ 2021-11-16 13:49 UTC (permalink / raw)
To: Siddhesh Poyarekar, libc-alpha, Szabolcs Nagy
On 16/11/2021 10:47, Siddhesh Poyarekar wrote:
> Hello,
>
> It looks like ordering related tests are failing on aarch64 with glibc built with --enable-static-pie. Anyone wants to take a look at this?
>
> The full build log is here:
> https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log
>
> Thanks,
> Siddhesh
>
>
> =====FAIL: elf/tst-bz15311.out=====
> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> =====FAIL: elf/tst-bz15311.test-result=====
> FAIL: elf/tst-bz15311
> original exit status 1
> =====FAIL: elf/tst-dso-ordering1.out=====
> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> =====FAIL: elf/tst-dso-ordering1.test-result=====
> FAIL: elf/tst-dso-ordering1
> original exit status 1
> =====FAIL: elf/tst-dso-ordering10.out=====
> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> =====FAIL: elf/tst-dso-ordering10.test-result=====
> FAIL: elf/tst-dso-ordering10
> original exit status 1
> =====FAIL: elf/tst-dso-ordering2.out=====
> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> =====FAIL: elf/tst-dso-ordering2.test-result=====
> FAIL: elf/tst-dso-ordering2
> original exit status 1
> =====FAIL: elf/tst-dso-ordering3.out=====
> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> =====FAIL: elf/tst-dso-ordering3.test-result=====
> FAIL: elf/tst-dso-ordering3
> original exit status 1
> =====FAIL: elf/tst-dso-ordering4.out=====
> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
I will take a look. It is strange that the GLIBC_TUNABLES=glibc.rtld.dynamic_sort=
is also failing because it is the previous algorithm.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: tst-dso-ordering* failing on aarch64 with --enable-static-pie
2021-11-16 13:49 ` Adhemerval Zanella
@ 2021-11-16 14:11 ` H.J. Lu
2021-11-16 14:23 ` Adhemerval Zanella
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2021-11-16 14:11 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: Siddhesh Poyarekar, GNU C Library, Szabolcs Nagy
On Tue, Nov 16, 2021 at 5:50 AM Adhemerval Zanella via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
>
>
> On 16/11/2021 10:47, Siddhesh Poyarekar wrote:
> > Hello,
> >
> > It looks like ordering related tests are failing on aarch64 with glibc built with --enable-static-pie. Anyone wants to take a look at this?
> >
> > The full build log is here:
> > https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log
> >
> > Thanks,
> > Siddhesh
> >
> >
> > =====FAIL: elf/tst-bz15311.out=====
> > FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> > FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> > =====FAIL: elf/tst-bz15311.test-result=====
> > FAIL: elf/tst-bz15311
> > original exit status 1
> > =====FAIL: elf/tst-dso-ordering1.out=====
> > FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> > FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> > =====FAIL: elf/tst-dso-ordering1.test-result=====
> > FAIL: elf/tst-dso-ordering1
> > original exit status 1
> > =====FAIL: elf/tst-dso-ordering10.out=====
> > FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> > FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> > =====FAIL: elf/tst-dso-ordering10.test-result=====
> > FAIL: elf/tst-dso-ordering10
> > original exit status 1
> > =====FAIL: elf/tst-dso-ordering2.out=====
> > FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> > FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> > =====FAIL: elf/tst-dso-ordering2.test-result=====
> > FAIL: elf/tst-dso-ordering2
> > original exit status 1
> > =====FAIL: elf/tst-dso-ordering3.out=====
> > FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> > FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
> > =====FAIL: elf/tst-dso-ordering3.test-result=====
> > FAIL: elf/tst-dso-ordering3
> > original exit status 1
> > =====FAIL: elf/tst-dso-ordering4.out=====
> > FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
> > FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>
> I will take a look. It is strange that the GLIBC_TUNABLES=glibc.rtld.dynamic_sort=
> is also failing because it is the previous algorithm.
Please try the current master. It may have been fixed.
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: tst-dso-ordering* failing on aarch64 with --enable-static-pie
2021-11-16 14:11 ` H.J. Lu
@ 2021-11-16 14:23 ` Adhemerval Zanella
2021-11-16 18:13 ` Adhemerval Zanella
0 siblings, 1 reply; 5+ messages in thread
From: Adhemerval Zanella @ 2021-11-16 14:23 UTC (permalink / raw)
To: H.J. Lu; +Cc: Siddhesh Poyarekar, GNU C Library, Szabolcs Nagy
On 16/11/2021 11:11, H.J. Lu wrote:
> On Tue, Nov 16, 2021 at 5:50 AM Adhemerval Zanella via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>>
>>
>> On 16/11/2021 10:47, Siddhesh Poyarekar wrote:
>>> Hello,
>>>
>>> It looks like ordering related tests are failing on aarch64 with glibc built with --enable-static-pie. Anyone wants to take a look at this?
>>>
>>> The full build log is here:
>>> https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log
>>>
>>> Thanks,
>>> Siddhesh
>>>
>>>
>>> =====FAIL: elf/tst-bz15311.out=====
>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>> =====FAIL: elf/tst-bz15311.test-result=====
>>> FAIL: elf/tst-bz15311
>>> original exit status 1
>>> =====FAIL: elf/tst-dso-ordering1.out=====
>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>> =====FAIL: elf/tst-dso-ordering1.test-result=====
>>> FAIL: elf/tst-dso-ordering1
>>> original exit status 1
>>> =====FAIL: elf/tst-dso-ordering10.out=====
>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>> =====FAIL: elf/tst-dso-ordering10.test-result=====
>>> FAIL: elf/tst-dso-ordering10
>>> original exit status 1
>>> =====FAIL: elf/tst-dso-ordering2.out=====
>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>> =====FAIL: elf/tst-dso-ordering2.test-result=====
>>> FAIL: elf/tst-dso-ordering2
>>> original exit status 1
>>> =====FAIL: elf/tst-dso-ordering3.out=====
>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>> =====FAIL: elf/tst-dso-ordering3.test-result=====
>>> FAIL: elf/tst-dso-ordering3
>>> original exit status 1
>>> =====FAIL: elf/tst-dso-ordering4.out=====
>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>
>> I will take a look. It is strange that the GLIBC_TUNABLES=glibc.rtld.dynamic_sort=
>> is also failing because it is the previous algorithm.
>
> Please try the current master. It may have been fixed.
Yes, that's my first though about this report. I am running make check on 128 core
aarch64 machine.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: tst-dso-ordering* failing on aarch64 with --enable-static-pie
2021-11-16 14:23 ` Adhemerval Zanella
@ 2021-11-16 18:13 ` Adhemerval Zanella
0 siblings, 0 replies; 5+ messages in thread
From: Adhemerval Zanella @ 2021-11-16 18:13 UTC (permalink / raw)
To: H.J. Lu; +Cc: Siddhesh Poyarekar, GNU C Library, Szabolcs Nagy
On 16/11/2021 11:23, Adhemerval Zanella wrote:
>
>
> On 16/11/2021 11:11, H.J. Lu wrote:
>> On Tue, Nov 16, 2021 at 5:50 AM Adhemerval Zanella via Libc-alpha
>> <libc-alpha@sourceware.org> wrote:
>>>
>>>
>>>
>>> On 16/11/2021 10:47, Siddhesh Poyarekar wrote:
>>>> Hello,
>>>>
>>>> It looks like ordering related tests are failing on aarch64 with glibc built with --enable-static-pie. Anyone wants to take a look at this?
>>>>
>>>> The full build log is here:
>>>> https://kojipkgs.fedoraproject.org//work/tasks/6697/78946697/build.log
>>>>
>>>> Thanks,
>>>> Siddhesh
>>>>
>>>>
>>>> =====FAIL: elf/tst-bz15311.out=====
>>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-bz15311(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-bz15311.test-result=====
>>>> FAIL: elf/tst-bz15311
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering1.out=====
>>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering1(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering1.test-result=====
>>>> FAIL: elf/tst-dso-ordering1
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering10.out=====
>>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering10(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering10.test-result=====
>>>> FAIL: elf/tst-dso-ordering10
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering2.out=====
>>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering2(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering2.test-result=====
>>>> FAIL: elf/tst-dso-ordering2
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering3.out=====
>>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering3(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>> =====FAIL: elf/tst-dso-ordering3.test-result=====
>>>> FAIL: elf/tst-dso-ordering3
>>>> original exit status 1
>>>> =====FAIL: elf/tst-dso-ordering4.out=====
>>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=1) execution test
>>>> FAIL: tst-dso-ordering4(GLIBC_TUNABLES=glibc.rtld.dynamic_sort=2) execution test
>>>
>>> I will take a look. It is strange that the GLIBC_TUNABLES=glibc.rtld.dynamic_sort=
>>> is also failing because it is the previous algorithm.
>>
>> Please try the current master. It may have been fixed.
>
> Yes, that's my first though about this report. I am running make check on 128 core
> aarch64 machine.
>
It is due my dl-minimal-malloc change (b05fae4d8e34), which requires the same
fixed done by 47618209d05a:
diff --git a/elf/dl-minimal-malloc.c b/elf/dl-minimal-malloc.c
index 939b5271ca..ea9bca26cf 100644
--- a/elf/dl-minimal-malloc.c
+++ b/elf/dl-minimal-malloc.c
@@ -17,6 +17,11 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+/* Mark symbols hidden in static PIE for early self relocation to work.
+ Note: string.h may have ifuncs which cannot be hidden on i686. */
+#if BUILD_PIE_DEFAULT
+# pragma GCC visibility push(hidden)
+#endif
#include <assert.h>
#include <string.h>
#include <ldsodefs.h>
I will run a make check on aarch64 and x86_64 and push the fix.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-16 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16 13:47 tst-dso-ordering* failing on aarch64 with --enable-static-pie Siddhesh Poyarekar
2021-11-16 13:49 ` Adhemerval Zanella
2021-11-16 14:11 ` H.J. Lu
2021-11-16 14:23 ` Adhemerval Zanella
2021-11-16 18:13 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).