* [PATCH] Guard tst-valgrind-smoke.out with run-built-tests
@ 2022-01-26 19:57 Mark Wielaard
2022-01-26 20:08 ` Adhemerval Zanella
0 siblings, 1 reply; 3+ messages in thread
From: Mark Wielaard @ 2022-01-26 19:57 UTC (permalink / raw)
To: libc-alpha; +Cc: Mark Wielaard
Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
---
elf/Makefile | 2 ++
1 file changed, 2 insertions(+)
Resent as separate PATCH to get it into patchwork.
diff --git a/elf/Makefile b/elf/Makefile
index daafb5cf12..775c755291 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -530,7 +530,9 @@ endif
endif
endif
+ifeq ($(run-built-tests),yes)
tests-special += $(objpfx)tst-valgrind-smoke.out
+endif
$(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test
$(SHELL) $< $(objpfx)ld.so $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \
'$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Guard tst-valgrind-smoke.out with run-built-tests
2022-01-26 19:57 [PATCH] Guard tst-valgrind-smoke.out with run-built-tests Mark Wielaard
@ 2022-01-26 20:08 ` Adhemerval Zanella
2022-01-26 22:49 ` Mark Wielaard
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2022-01-26 20:08 UTC (permalink / raw)
To: Mark Wielaard, libc-alpha
On 26/01/2022 16:57, Mark Wielaard wrote:
> Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> elf/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> Resent as separate PATCH to get it into patchwork.
>
> diff --git a/elf/Makefile b/elf/Makefile
> index daafb5cf12..775c755291 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -530,7 +530,9 @@ endif
> endif
> endif
>
> +ifeq ($(run-built-tests),yes)
> tests-special += $(objpfx)tst-valgrind-smoke.out
> +endif
> $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test
> $(SHELL) $< $(objpfx)ld.so $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \
> '$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Guard tst-valgrind-smoke.out with run-built-tests
2022-01-26 20:08 ` Adhemerval Zanella
@ 2022-01-26 22:49 ` Mark Wielaard
0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2022-01-26 22:49 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
Hi,
On Wed, Jan 26, 2022 at 05:08:48PM -0300, Adhemerval Zanella wrote:
> On 26/01/2022 16:57, Mark Wielaard wrote:
> > Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Thanks. The patchwork trybot is also green.
Pushed,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-26 22:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 19:57 [PATCH] Guard tst-valgrind-smoke.out with run-built-tests Mark Wielaard
2022-01-26 20:08 ` Adhemerval Zanella
2022-01-26 22:49 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).