* nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
@ 2016-11-04 21:37 Joseph Myers
2016-11-16 5:31 ` Mike Frysinger
0 siblings, 1 reply; 5+ messages in thread
From: Joseph Myers @ 2016-11-04 21:37 UTC (permalink / raw)
To: libc-alpha, Chung-Lin Tang
nios2 glibc compile-only test results include:
FAIL: misc/check-installed-headers-c
FAIL: misc/check-installed-headers-cxx
This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
kernel has no such header. How is this meant to work? Should that
#include just be removed?
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
2016-11-04 21:37 nios2 sys/cachectl.h includes nonexistent asm/cachectl.h Joseph Myers
@ 2016-11-16 5:31 ` Mike Frysinger
2016-11-16 18:45 ` Joseph Myers
0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2016-11-16 5:31 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha, Chung-Lin Tang
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On 04 Nov 2016 21:37, Joseph Myers wrote:
> nios2 glibc compile-only test results include:
>
> FAIL: misc/check-installed-headers-c
> FAIL: misc/check-installed-headers-cxx
>
> This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
> kernel has no such header. How is this meant to work? Should that
> #include just be removed?
delete it for now. looks like they speced it out for future usage,
but haven't yet gotten around to it. the kernel will explicitly
throw an error if the |op| field is non-zero.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
2016-11-16 5:31 ` Mike Frysinger
@ 2016-11-16 18:45 ` Joseph Myers
2016-11-21 16:48 ` Ping " Joseph Myers
2016-11-27 7:14 ` Mike Frysinger
0 siblings, 2 replies; 5+ messages in thread
From: Joseph Myers @ 2016-11-16 18:45 UTC (permalink / raw)
To: Mike Frysinger; +Cc: libc-alpha, Chung-Lin Tang
On Tue, 15 Nov 2016, Mike Frysinger wrote:
> On 04 Nov 2016 21:37, Joseph Myers wrote:
> > nios2 glibc compile-only test results include:
> >
> > FAIL: misc/check-installed-headers-c
> > FAIL: misc/check-installed-headers-cxx
> >
> > This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
> > kernel has no such header. How is this meant to work? Should that
> > #include just be removed?
>
> delete it for now. looks like they speced it out for future usage,
> but haven't yet gotten around to it. the kernel will explicitly
> throw an error if the |op| field is non-zero.
This patch does that.
Do not include asm/cachectl.h in nios2 sys/cachectl.h.
The nios2 sys/cachectl.h includes a kernel header asm/cachectl.h,
which does not exist, so causing the check-installed-headers tests to
fail. This patch removes the include of a nonexistent header.
Tested (compilation only) for nios2.
2016-11-16 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/nios2/sys/cachectl.h: Do not include
<asm/cachectl.h>.
diff --git a/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h b/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h
index 717e6ae..d4e6b2e 100644
--- a/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h
+++ b/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h
@@ -21,9 +21,6 @@
#include <features.h>
-/* Get the kernel definition for the op bits. */
-#include <asm/cachectl.h>
-
__BEGIN_DECLS
#ifdef __USE_MISC
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Ping Re: nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
2016-11-16 18:45 ` Joseph Myers
@ 2016-11-21 16:48 ` Joseph Myers
2016-11-27 7:14 ` Mike Frysinger
1 sibling, 0 replies; 5+ messages in thread
From: Joseph Myers @ 2016-11-21 16:48 UTC (permalink / raw)
To: Mike Frysinger; +Cc: libc-alpha, Chung-Lin Tang
Ping. This patch
<https://sourceware.org/ml/libc-alpha/2016-11/msg00584.html> is pending
review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
2016-11-16 18:45 ` Joseph Myers
2016-11-21 16:48 ` Ping " Joseph Myers
@ 2016-11-27 7:14 ` Mike Frysinger
1 sibling, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2016-11-27 7:14 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha, Chung-Lin Tang
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
On 16 Nov 2016 18:45, Joseph Myers wrote:
> On Tue, 15 Nov 2016, Mike Frysinger wrote:
> > On 04 Nov 2016 21:37, Joseph Myers wrote:
> > > nios2 glibc compile-only test results include:
> > >
> > > FAIL: misc/check-installed-headers-c
> > > FAIL: misc/check-installed-headers-cxx
> > >
> > > This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
> > > kernel has no such header. How is this meant to work? Should that
> > > #include just be removed?
> >
> > delete it for now. looks like they speced it out for future usage,
> > but haven't yet gotten around to it. the kernel will explicitly
> > throw an error if the |op| field is non-zero.
>
> This patch does that.
>
> Do not include asm/cachectl.h in nios2 sys/cachectl.h.
>
> The nios2 sys/cachectl.h includes a kernel header asm/cachectl.h,
> which does not exist, so causing the check-installed-headers tests to
> fail. This patch removes the include of a nonexistent header.
lgtm
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-27 7:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 21:37 nios2 sys/cachectl.h includes nonexistent asm/cachectl.h Joseph Myers
2016-11-16 5:31 ` Mike Frysinger
2016-11-16 18:45 ` Joseph Myers
2016-11-21 16:48 ` Ping " Joseph Myers
2016-11-27 7:14 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).