From: Joseph Myers <joseph@codesourcery.com>
To: Steve Ellcey <sellcey@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Speed up math/test-tgmath2.c
Date: Fri, 04 Nov 2016 22:06:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611042205560.19848@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1478296927.4630.32.camel@caviumnetworks.com>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Fri, 4 Nov 2016, Steve Ellcey wrote:
> On Fri, 2016-11-04 at 21:26 +0000, Joseph Myers wrote:
> > On Fri, 4 Nov 2016, Steve Ellcey wrote:
> >
> > >
> > > Here is a modified and retested patch.
> > The expression ORing together lots of function call results hasÂ
> > indeterminate order of evaluation.  While the test should work
> > running theÂ
> > test functions in any order, on the whole I think it would be better
> > toÂ
> > make the order determinate, by doing
> >
> > result = test_cos (vint1, vllong1);
> > result |= test_fabs (vint1, vllong1);
> >
> > etc.
>
> Having a determinate order of execution would make it easier when
> analyzing a failure. Â Here is a new version.
This version is OK.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2016-11-04 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 0:16 Steve Ellcey
2016-11-04 17:22 ` Steve Ellcey
2016-11-04 17:26 ` Joseph Myers
2016-11-04 18:06 ` Steve Ellcey
2016-11-04 21:22 ` Joseph Myers
2016-11-04 21:06 ` Steve Ellcey
2016-11-04 21:27 ` Joseph Myers
2016-11-04 22:02 ` Steve Ellcey
2016-11-04 22:06 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611042205560.19848@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=sellcey@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).