public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Steve Ellcey <sellcey@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Speed up math/test-tgmath2.c
Date: Fri, 04 Nov 2016 17:26:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.20.1611041724170.25235@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1478280156.4630.18.camel@caviumnetworks.com>

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Fri, 4 Nov 2016, Steve Ellcey wrote:

> > +  return test_cos (vint1, vllong1)
> > +	 + test_fabs (vint1, vllong1)
> > +	 + test_conj (vint1, vllong1)
> > +	 + test_expm1 (vint1, vllong1)
> > +	 + test_lrint (vint1, vllong1)
> > +	 + test_ldexp (vint1, vllong1)
> > +	 + test_atan2 (vint1, vllong1)
> > +	 + test_remquo (vint1, vllong1)
> > +	 + test_pow (vint1, vllong1)
> > +	 + test_fma_1 (vint1, vllong1)
> > +	 + test_fma_2 (vint1, vllong1)
> > +	 + test_fma_3 (vint1, vllong1)
> > +	 + test_fma_4 (vint1, vllong1);

You don't want to add up test results like that; you should OR them 
together instead, to avoid the potential for test results adding up to 77 
and wrongly becoming UNSUPPORTED.  (In this case of course there aren't 
enough tests to get to 77, but the principle applies that you should avoid 
the test return being a count of something.)

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2016-11-04 17:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  0:16 Steve Ellcey
2016-11-04 17:22 ` Steve Ellcey
2016-11-04 17:26   ` Joseph Myers [this message]
2016-11-04 18:06     ` Steve Ellcey
2016-11-04 21:22       ` Joseph Myers
2016-11-04 21:06     ` Steve Ellcey
2016-11-04 21:27       ` Joseph Myers
2016-11-04 22:02         ` Steve Ellcey
2016-11-04 22:06           ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1611041724170.25235@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=sellcey@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).