From: Joseph Myers <josmyers@redhat.com>
To: caiyinyu <caiyinyu@loongson.cn>
Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org,
xry111@xry111.site, xuchenghua@loongson.cn
Subject: Re: [PATCH] LoongArch: Add soft floating-point fe* function implementations.
Date: Wed, 27 Mar 2024 17:10:49 +0000 (UTC) [thread overview]
Message-ID: <b8b3e43f-77b6-c2ea-1be8-9828b4684a14@redhat.com> (raw)
In-Reply-To: <2193d4f3-6f55-1812-5923-2845226b3011@loongson.cn>
On Wed, 27 Mar 2024, caiyinyu wrote:
> Yes, this patch does make sense in both libc and libm and it can be proved by
> the following glibc tests:
Please explain more how it works.
> All the functions Implemented in this patch are exported from libm.so the same
> as powerpc nofpu.
I'm talking about functions such as __adddf3 (which would need to be
exported from libc, not libm, to provide exceptions / rounding modes
support for software floating point). I don't see them in any Versions
file for LoongArch.
Furthermore, this patch isn't changing sfp-machine.h for LoongArch, which
uses fpu_control.h to get rounding mode / exceptions state, and it isn't
changing how fpu_control.h uses constant 0 for that state in the
soft-float case. So I don't see how it would produce *working* exceptions
/ rounding modes support for software floating-point arithmetic.
--
Joseph S. Myers
josmyers@redhat.com
next prev parent reply other threads:[~2024-03-27 17:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 12:46 caiyinyu
2024-03-26 17:34 ` Joseph Myers
2024-03-27 8:42 ` caiyinyu
2024-03-27 17:10 ` Joseph Myers [this message]
2024-03-31 10:14 ` caiyinyu
2024-04-01 13:19 ` Florian Weimer
2024-04-02 3:40 ` caiyinyu
2024-04-02 10:40 ` Xi Ruoyao
2024-04-02 11:45 ` Florian Weimer
2024-04-02 12:02 ` Xi Ruoyao
2024-04-02 12:34 ` Florian Weimer
2024-04-02 12:12 ` Andreas Schwab
2024-04-02 21:18 ` Joseph Myers
2024-03-31 10:31 ` caiyinyu
2024-04-02 21:10 ` Joseph Myers
2024-04-02 14:46 caiyinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b3e43f-77b6-c2ea-1be8-9828b4684a14@redhat.com \
--to=josmyers@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).