public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Xi Ruoyao <xry111@xry111.site>
Cc: caiyinyu <caiyinyu@loongson.cn>,
	 Florian Weimer <fweimer@redhat.com>,
	josmyers@redhat.com,  libc-alpha@sourceware.org,
	adhemerval.zanella@linaro.org
Subject: Re: [PATCH] LoongArch: Add soft floating-point fe* function implementations.
Date: Tue, 02 Apr 2024 14:12:10 +0200	[thread overview]
Message-ID: <mvmo7asdkv9.fsf@suse.de> (raw)
In-Reply-To: <98f2d5adc158e05a3fa487a8a3a3899734b97a45.camel@xry111.site> (Xi Ruoyao's message of "Tue, 02 Apr 2024 18:40:06 +0800")

On Apr 02 2024, Xi Ruoyao wrote:

> The problem is this change is breaking ABI.  The behavior of
> feenableexcept etc. *is* a part of the ABI.  For example, if a not so
> careful programmer invokes feenableexcept(FE_INVALID) and then
> mistakenly invokes something like acos(1.0000001), before this change
> the program will continue to run with a NaN, but after this change it'll
> crash with SIGFPE.

If you ask for FE_INVALID exceptions, you need to be prepared for them.
This is not the default mode of operation.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  parent reply	other threads:[~2024-04-02 12:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 12:46 caiyinyu
2024-03-26 17:34 ` Joseph Myers
2024-03-27  8:42   ` caiyinyu
2024-03-27 17:10     ` Joseph Myers
2024-03-31 10:14       ` caiyinyu
2024-04-01 13:19         ` Florian Weimer
2024-04-02  3:40           ` caiyinyu
2024-04-02 10:40             ` Xi Ruoyao
2024-04-02 11:45               ` Florian Weimer
2024-04-02 12:02                 ` Xi Ruoyao
2024-04-02 12:34                   ` Florian Weimer
2024-04-02 12:12               ` Andreas Schwab [this message]
2024-04-02 21:18             ` Joseph Myers
2024-03-31 10:31       ` caiyinyu
2024-04-02 21:10         ` Joseph Myers
2024-04-02 14:46 caiyinyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmo7asdkv9.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=adhemerval.zanella@linaro.org \
    --cc=caiyinyu@loongson.cn \
    --cc=fweimer@redhat.com \
    --cc=josmyers@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).