* [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency
@ 2022-07-29 17:50 H.J. Lu
2022-07-29 18:02 ` Sunil Pandey
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: H.J. Lu @ 2022-07-29 17:50 UTC (permalink / raw)
To: libc-alpha
Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
xsetlocale (LC_ALL, "de_DE.UTF-8");
xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
---
wcsmbs/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
index e6b9e8743a..3d19d5556f 100644
--- a/wcsmbs/Makefile
+++ b/wcsmbs/Makefile
@@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
$(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
$(objpfx)tst-c16-surrogate.out: $(gen-locales)
$(objpfx)tst-c32-state.out: $(gen-locales)
+$(objpfx)test-c8rtomb.out: $(gen-locales)
+$(objpfx)test-mbrtoc8.out: $(gen-locales)
endif
$(objpfx)tst-wcstod-round: $(libm)
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency
2022-07-29 17:50 [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency H.J. Lu
@ 2022-07-29 18:02 ` Sunil Pandey
2022-07-29 19:08 ` Adhemerval Zanella Netto
2022-07-31 11:57 ` Carlos O'Donell
2 siblings, 0 replies; 4+ messages in thread
From: Sunil Pandey @ 2022-07-29 18:02 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library
On Fri, Jul 29, 2022 at 10:51 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
> xsetlocale (LC_ALL, "de_DE.UTF-8");
> xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
> wcsmbs/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
> $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
> $(objpfx)tst-c16-surrogate.out: $(gen-locales)
> $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
> endif
>
> $(objpfx)tst-wcstod-round: $(libm)
> --
> 2.37.1
>
Fixes the issue.
LGTM
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency
2022-07-29 17:50 [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency H.J. Lu
2022-07-29 18:02 ` Sunil Pandey
@ 2022-07-29 19:08 ` Adhemerval Zanella Netto
2022-07-31 11:57 ` Carlos O'Donell
2 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella Netto @ 2022-07-29 19:08 UTC (permalink / raw)
To: libc-alpha
On 29/07/22 14:50, H.J. Lu via Libc-alpha wrote:
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
> xsetlocale (LC_ALL, "de_DE.UTF-8");
> xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
> wcsmbs/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
> $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
> $(objpfx)tst-c16-surrogate.out: $(gen-locales)
> $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
> endif
>
> $(objpfx)tst-wcstod-round: $(libm)
LGTM as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency
2022-07-29 17:50 [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency H.J. Lu
2022-07-29 18:02 ` Sunil Pandey
2022-07-29 19:08 ` Adhemerval Zanella Netto
@ 2022-07-31 11:57 ` Carlos O'Donell
2 siblings, 0 replies; 4+ messages in thread
From: Carlos O'Donell @ 2022-07-31 11:57 UTC (permalink / raw)
To: H.J. Lu, libc-alpha
On 7/29/22 13:50, H.J. Lu via Libc-alpha wrote:
> Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for
>
> xsetlocale (LC_ALL, "de_DE.UTF-8");
> xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS");
> ---
> wcsmbs/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile
> index e6b9e8743a..3d19d5556f 100644
> --- a/wcsmbs/Makefile
> +++ b/wcsmbs/Makefile
> @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales)
> $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales)
> $(objpfx)tst-c16-surrogate.out: $(gen-locales)
> $(objpfx)tst-c32-state.out: $(gen-locales)
> +$(objpfx)test-c8rtomb.out: $(gen-locales)
> +$(objpfx)test-mbrtoc8.out: $(gen-locales)
> endif
>
> $(objpfx)tst-wcstod-round: $(libm)
LGTM. OK for 2.36 also.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-31 11:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 17:50 [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency H.J. Lu
2022-07-29 18:02 ` Sunil Pandey
2022-07-29 19:08 ` Adhemerval Zanella Netto
2022-07-31 11:57 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).