From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: stsp <stsp2@yandex.ru>,
libc-alpha@sourceware.org, Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: [PATCH 03/13] elf: dont pass fd to _dl_process_pt_xx
Date: Thu, 30 Mar 2023 17:46:54 -0300 [thread overview]
Message-ID: <f1488b83-edf3-1c8f-a213-ad5e5fff726f@linaro.org> (raw)
In-Reply-To: <cd478256-9859-efc5-aebf-773f5c6c5f48@yandex.ru>
On 30/03/23 13:08, stsp wrote:
>
> 29.03.2023 22:10, Adhemerval Zanella Netto пишет:
>>
>> On 18/03/23 13:51, Stas Sergeev via Libc-alpha wrote:
>>> It is not used in these functions.
>>> rtld.c:rtld_setup_main_map() does the same.
>>>
>>> The test-suite was run on x86_64/64 and showed no regressions.
>>>
>>> Signed-off-by: Stas Sergeev <stsp2@yandex.ru>
>>> ---
>>> elf/dl-load.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/elf/dl-load.c b/elf/dl-load.c
>>> index fcb39a78d4..ab8b648687 100644
>>> --- a/elf/dl-load.c
>>> +++ b/elf/dl-load.c
>>> @@ -1379,10 +1379,10 @@ cannot enable executable stack as shared object requires");
>>> switch (ph[-1].p_type)
>>> {
>>> case PT_NOTE:
>>> - _dl_process_pt_note (l, fd, &ph[-1]);
>>> + _dl_process_pt_note (l, -1, &ph[-1]);
>>> break;
>>> case PT_GNU_PROPERTY:
>>> - _dl_process_pt_gnu_property (l, fd, &ph[-1]);
>>> + _dl_process_pt_gnu_property (l, -1, &ph[-1]);
>>> break;
>>> }
>>>
>>
>> It allows both _dl_process_pt_note and _dl_process_pt_gnu_property to know
>> if the called where rtld code during statup code or dlopen. But you are
>> right that it is not used.
>>
>> However this does not accomplish anything, a better refactor would to just
>> remove the argument altogether. It at least would simplify the interface
>> and allow slight better code generation.
>
> I tried to do that, but there is also that
> _dl_process_gnu_property() called from
> _dl_process_pt_gnu_property().
> For aarch64 it has this:
> unsigned int feature_1 = *(unsigned int *) data;
> if (feature_1 & GNU_PROPERTY_AARCH64_FEATURE_1_BTI)
> _dl_bti_protect (l, fd);
>
> What should I do here to remove that fd?
>
In fact aarch64 _dl_bti_protect requires to know whether the map was done by
the kernel or not.
Szabolcs, shouldn't the code:
1257 for (const ElfW(Phdr) *ph = &phdr[phnum]; ph != phdr; --ph)
1258 switch (ph[-1].p_type)
1259 {
1260 case PT_NOTE:
1261 _dl_process_pt_note (main_map, -1, &ph[-1]);
1262 break;
1263 case PT_GNU_PROPERTY:
1264 _dl_process_pt_gnu_property (main_map, -1, &ph[-1]);
1265 break;
1266 }
Take in consideration whether the main_map was allocated by the kernel or
by loader to pass the correct value on 'fd'?
next prev parent reply other threads:[~2023-03-30 20:46 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 16:50 [PATCH v9 0/13] implement dlmem() function Stas Sergeev
2023-03-18 16:50 ` [PATCH 01/13] elf: strdup() l_name if no realname [BZ #30100] Stas Sergeev
2023-03-29 13:54 ` Adhemerval Zanella Netto
2023-03-29 14:12 ` stsp
2023-03-29 14:19 ` Adhemerval Zanella Netto
2023-03-29 14:28 ` stsp
2023-03-29 14:30 ` Adhemerval Zanella Netto
2023-03-29 14:33 ` stsp
2023-03-18 16:50 ` [PATCH 02/13] elf: switch _dl_map_segment() to anonymous mapping Stas Sergeev
2023-03-29 17:01 ` Adhemerval Zanella Netto
2023-03-29 18:00 ` stsp
2023-03-29 18:29 ` Adhemerval Zanella Netto
2023-03-29 18:46 ` stsp
2023-03-29 19:17 ` Adhemerval Zanella Netto
2023-03-29 19:43 ` stsp
2023-03-18 16:51 ` [PATCH 03/13] elf: dont pass fd to _dl_process_pt_xx Stas Sergeev
2023-03-29 17:10 ` Adhemerval Zanella Netto
2023-03-30 16:08 ` stsp
2023-03-30 20:46 ` Adhemerval Zanella Netto [this message]
2023-03-31 12:02 ` Szabolcs Nagy
2023-03-31 12:54 ` Adhemerval Zanella Netto
2023-03-31 14:04 ` stsp
2023-03-18 16:51 ` [PATCH 04/13] elf: split _dl_map_object_from_fd() into reusable parts Stas Sergeev
2023-03-18 16:51 ` [PATCH 05/13] elf: split open_verify() " Stas Sergeev
2023-03-18 16:51 ` [PATCH 06/13] elf: load elf hdr fully in open_verify() Stas Sergeev
2023-03-18 16:51 ` [PATCH 07/13] elf: convert pread64 to callback in do_open_verify() Stas Sergeev
2023-03-18 16:51 ` [PATCH 08/13] elf: convert _dl_map_segments's mmap() to a callback Stas Sergeev
2023-03-18 16:51 ` [PATCH 09/13] elf: call _dl_map_segment() via premap callback Stas Sergeev
2023-03-18 16:51 ` [PATCH 10/13] elf: convert _dl_map_object to a callback Stas Sergeev
2023-03-18 16:51 ` [PATCH 11/13] elf: split _dl_check_loaded() from _dl_map_object Stas Sergeev
2023-03-18 16:51 ` [PATCH 12/13] dlfcn,elf: implement dlmem() [BZ #11767] Stas Sergeev
2023-03-29 13:45 ` Carlos O'Donell
2023-03-29 13:51 ` stsp
2023-03-29 14:10 ` Jonathon Anderson
2023-03-29 14:20 ` stsp
2023-03-29 14:31 ` Adhemerval Zanella Netto
2023-03-29 15:01 ` stsp
2023-03-29 14:35 ` Carlos O'Donell
2023-03-29 14:50 ` stsp
2023-03-29 15:20 ` Carlos O'Donell
2023-03-29 15:34 ` stsp
2023-03-30 8:09 ` stsp
2023-03-18 16:51 ` [PATCH 13/13] dlfcn,elf: impl DLMEM_DONTREPLACE dlmem() flag Stas Sergeev
2023-03-29 12:32 ` [PATCH v9 0/13] implement dlmem() function Adhemerval Zanella Netto
2023-03-29 13:10 ` stsp
2023-03-29 13:18 ` stsp
2023-03-31 12:20 ` Szabolcs Nagy
2023-03-31 13:51 ` stsp
2023-03-31 14:49 ` Rich Felker
2023-03-31 14:56 ` stsp
2023-03-31 14:58 ` Rich Felker
2023-03-31 15:03 ` stsp
2023-03-31 14:44 ` stsp
2023-03-31 15:12 ` stsp
2023-03-31 17:12 ` Szabolcs Nagy
2023-03-31 17:36 ` stsp
2023-04-01 9:28 ` stsp
2023-04-03 10:04 ` Szabolcs Nagy
2023-04-03 10:43 ` stsp
2023-04-03 12:01 ` Szabolcs Nagy
2023-04-03 13:07 ` stsp
2023-04-05 7:29 ` stsp
2023-04-05 8:51 ` Szabolcs Nagy
2023-04-05 9:26 ` stsp
2023-04-05 9:31 ` Florian Weimer
2023-04-12 17:23 ` stsp
2023-04-12 18:00 ` stsp
2023-04-12 18:20 ` Rich Felker
2023-04-12 18:46 ` stsp
2023-04-12 19:52 ` Zack Weinberg
2023-04-12 19:07 ` stsp
2023-04-13 10:01 ` stsp
2023-04-13 12:38 ` Szabolcs Nagy
2023-04-13 15:59 ` stsp
2023-04-13 18:09 ` Adhemerval Zanella Netto
2023-04-13 18:59 ` stsp
2023-04-13 19:12 ` Adhemerval Zanella Netto
2023-04-13 19:29 ` stsp
2023-04-13 20:02 ` Adhemerval Zanella Netto
2023-04-13 20:21 ` stsp
2023-04-13 20:57 ` stsp
2023-04-14 7:07 ` stsp
2023-04-14 7:36 ` stsp
2023-04-14 11:30 ` stsp
2023-04-14 19:04 ` proof for dlmem() (Re: [PATCH v9 0/13] implement dlmem() function) stsp
2023-05-01 23:11 ` Zack Weinberg
2023-05-02 5:48 ` stsp
2023-05-08 16:00 ` stsp
2023-05-02 6:24 ` stsp
2023-05-08 15:10 ` [PATCH v9 0/13] implement dlmem() function stsp
2023-03-31 18:47 ` stsp
2023-03-31 19:00 ` stsp
2023-03-29 13:17 ` Carlos O'Donell
2023-03-29 13:26 ` stsp
2023-03-29 17:03 ` stsp
2023-03-29 18:13 ` Carlos O'Donell
2023-03-29 18:29 ` stsp
2023-03-31 11:04 ` stsp
2023-04-13 21:17 ` Carlos O'Donell
2023-04-13 21:58 ` stsp
2023-04-13 22:08 ` stsp
2023-04-13 22:50 ` stsp
2023-04-14 16:15 ` Autoconf maintenance (extremely tangential to Re: [PATCH v9 0/13] implement dlmem() function) Zack Weinberg
2023-04-14 20:24 ` Carlos O'Donell
2023-04-14 20:40 ` Zack Weinberg
2023-05-08 15:05 ` [PATCH v9 0/13] implement dlmem() function stsp
2023-05-19 7:26 ` stsp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1488b83-edf3-1c8f-a213-ad5e5fff726f@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=stsp2@yandex.ru \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).