From: Richard Henderson <rth@twiddle.net>
To: Steven Munroe <munroesj@us.ibm.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>,
Ulrich Drepper <drepper@redhat.com>,
Peter Eberlein <eberlein@us.ibm.com>
Subject: Re: [PATCH] PPC fenv fixes.
Date: Thu, 05 Apr 2007 02:27:00 -0000 [thread overview]
Message-ID: <20070405022655.GA29766@twiddle.net> (raw)
In-Reply-To: <460A8D78.6060303@us.ibm.com>
On Wed, Mar 28, 2007 at 10:44:56AM -0500, Steven Munroe wrote:
> performance penalty (but have no other visible effect). */
> extern const fenv_t *__fe_nomask_env (void);
> # define FE_NOMASK_ENV (__fe_nomask_env ())
> +
> +/* Floating-point environment with all exceptions disabled. */
> +extern const fenv_t *__fe_mask_env (void);
> +# define FE_MASK_ENV (__fe_mask_env ())
This is incorrect. The mere evaluation of FE_NOMASK_ENV/FE_MASK_ENV
should have no effect at all. This stuff should be delayed until
the environment is actually installed.
You should be using magic numbers, like in the i386 port.
r~
next prev parent reply other threads:[~2007-04-05 2:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 14:49 [PATCH] fenv fixes for x86_64/i386/ia64 Jakub Jelinek
2007-03-22 21:46 ` Steven Munroe
2007-03-27 15:53 ` [PATCH] PPC fenv fixes Steven Munroe
[not found] ` <20070327160708.GA355@devserv.devel.redhat.com>
2007-03-27 18:07 ` Steven Munroe
2007-03-28 15:29 ` Steven Munroe
2007-04-05 2:27 ` Richard Henderson [this message]
2007-04-05 22:00 ` [PATCH] PPC fenv fixes. 3rd update Steven Munroe
2007-04-14 17:32 ` Jakub Jelinek
2007-04-17 0:09 ` Richard Henderson
[not found] ` <20070417002157.GI355@devserv.devel.redhat.com>
2007-04-30 21:45 ` Steven Munroe
2007-04-02 16:43 ` [PATCH] [PORTS] PPC fenv fixes for soft-fp Steven Munroe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405022655.GA29766@twiddle.net \
--to=rth@twiddle.net \
--cc=drepper@redhat.com \
--cc=eberlein@us.ibm.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=munroesj@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).