From: Steven Munroe <munroesj@us.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>,
Ulrich Drepper <drepper@redhat.com>,
Peter Eberlein <eberlein@us.ibm.com>
Subject: Re: [PATCH] PPC fenv fixes.
Date: Tue, 27 Mar 2007 18:07:00 -0000 [thread overview]
Message-ID: <46096124.6050504@us.ibm.com> (raw)
In-Reply-To: <20070327160708.GA355@devserv.devel.redhat.com>
Jakub Jelinek wrote:
> On Tue, Mar 27, 2007 at 11:09:28AM -0500, Steven Munroe wrote:
>
>> 2007-03-26 Steven Munroe <sjmunroe@us.ibm.com>
>>
>> * sysdeps/powerpc/fpu/feupdateenv.c: Change mask to merge exceptions
>> from env.
>>
>
> Will that actually raise SIGFPE signals when exceptions are enabled?
> From my reading of POSIX that's what should happen with the
> `old' exceptions (and other arches are calling feraiseexcept that will do
> that). I didn't add a testcase for it because I'm not 100% sure about that.
>
>
hmmm not unless the SIGFPE is eanbled by the MSR FE bits. So we will
need to call __fe_nomask_env() in feupdateenv similar to what we do in
feenableexcept(). Probably should add the __fe_mask_env() call for when
the application remasks FP exceptions. This allows the hardware to run
faster when we are taking the default action.
I will rework the patch.
next prev parent reply other threads:[~2007-03-27 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 14:49 [PATCH] fenv fixes for x86_64/i386/ia64 Jakub Jelinek
2007-03-22 21:46 ` Steven Munroe
2007-03-27 15:53 ` [PATCH] PPC fenv fixes Steven Munroe
[not found] ` <20070327160708.GA355@devserv.devel.redhat.com>
2007-03-27 18:07 ` Steven Munroe [this message]
2007-03-28 15:29 ` Steven Munroe
2007-04-05 2:27 ` Richard Henderson
2007-04-05 22:00 ` [PATCH] PPC fenv fixes. 3rd update Steven Munroe
2007-04-14 17:32 ` Jakub Jelinek
2007-04-17 0:09 ` Richard Henderson
[not found] ` <20070417002157.GI355@devserv.devel.redhat.com>
2007-04-30 21:45 ` Steven Munroe
2007-04-02 16:43 ` [PATCH] [PORTS] PPC fenv fixes for soft-fp Steven Munroe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46096124.6050504@us.ibm.com \
--to=munroesj@us.ibm.com \
--cc=drepper@redhat.com \
--cc=eberlein@us.ibm.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).