public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Use __LONG_LONG_PAIR in linux/sync_file_range.c
@ 2006-04-24 10:11 Jakub Jelinek
  2006-04-24 17:08 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2006-04-24 10:11 UTC (permalink / raw)
  To: Ulrich Drepper, Roland McGrath; +Cc: Glibc hackers

Hi!

So far I think none of the 32-bit big endian arches support this syscall
(and ppc32 will likely need its own implementation of this, as it requires
long long args to be at padded to even arguments), but certainly it doesn't
hurt to follow what linux/posix_fadvise{,64}.c is already doing.

2006-04-24  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/sync_file_range.c (sync_file_range): Use
	__LONG_LONG_PAIR macro.

--- libc/sysdeps/unix/sysv/linux/sync_file_range.c	14 Apr 2006 08:07:56 -0000	1.1
+++ libc/sysdeps/unix/sysv/linux/sync_file_range.c	24 Apr 2006 10:01:53 -0000
@@ -29,9 +29,10 @@
 int
 sync_file_range (int fd, __off64_t from, __off64_t to, int flags)
 {
-  return INLINE_SYSCALL (sync_file_range, 6, fd, (off_t) (from >> 32),
-			 (off_t) (from & 0xffffffff), (off_t) (to >> 32),
-			 (off_t) (to & 0xffffffff), flags);
+  return INLINE_SYSCALL (sync_file_range, 6, fd,
+			 __LONG_LONG_PAIR ((long) (from >> 32), (long) from),
+			 __LONG_LONG_PAIR ((long) (to >> 32), (long) to),
+			 flags);
 }
 #else
 int

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use __LONG_LONG_PAIR in linux/sync_file_range.c
  2006-04-24 10:11 [PATCH] Use __LONG_LONG_PAIR in linux/sync_file_range.c Jakub Jelinek
@ 2006-04-24 17:08 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2006-04-24 17:08 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Glibc hackers

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

Applied.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-04-24 17:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-24 10:11 [PATCH] Use __LONG_LONG_PAIR in linux/sync_file_range.c Jakub Jelinek
2006-04-24 17:08 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).