New patch help...

New patch help...

[John McCabe]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Apologies if I just appear a bit dim, but I've just reported a bug on 
the glibc documentation, so have tried to follow the instructions to 
also fix it, as it's relatively easy. To be honest though, I've not used 
git in much depth really, so I'm slightly lost and wonder if you could 
advise me.

Attached is the patch I've generated, based on master; I feel that there 
is probably something missing but I'm not totally sure. If you could let 
me know, that would be useful.

Also the "new committer" bit mentions about FSF copyright assignment; as 
far as I remember, I signed something when I was sending patches into 
GNU Emacs - would that still be valid?

Many thanks.
John

[-- Attachment #2: 0001-manual-Correct-argument-order-in-mount-examples-bug-.patch --]
[-- Type: application/octet-stream, Size: 862 bytes --]

From 29171f18cbc325000a84d585ad298ba78eb9941b Mon Sep 17 00:00:00 2001
From: John McCabe <jmccabe@kirintec.com>
Date: Tue, 19 Jan 2021 18:25:25 +0000
Subject: [PATCH] manual: Correct argument order in mount examples (bug 27207)
To: libc-alpha@sourceware.org

---
 manual/sysinfo.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/manual/sysinfo.texi b/manual/sysinfo.texi
index 4ca4555443..8a10428774 100644
--- a/manual/sysinfo.texi
+++ b/manual/sysinfo.texi
@@ -954,9 +954,9 @@ Example:
 @group
 #include <sys/mount.h>
 
-mount("/dev/hdb", "/cdrom", MS_MGC_VAL | MS_RDONLY | MS_NOSUID, "");
+mount("/dev/hdb", "/cdrom", "", MS_MGC_VAL | MS_RDONLY | MS_NOSUID);
 
-mount("/dev/hda2", "/mnt", MS_MGC_VAL | MS_REMOUNT, "");
+mount("/dev/hda2", "/mnt", "", MS_MGC_VAL | MS_REMOUNT);
 
 @end group
 @end smallexample
-- 
2.30.0.windows.2

Re: New patch help...

[Carlos O'Donell]

On 1/19/21 1:40 PM, John McCabe wrote:
> Also the "new committer" bit mentions about FSF copyright assignment;
> as far as I remember, I signed something when I was sending patches
> into GNU Emacs - would that still be valid?

Your current change is mechanical and changes 2 lines, and so is usually
below the limit under which we require copyright assignment. So we could
accept your changes. Note that patches go to libc-alpha for review.

Copyright assignment is per package.

To accept larger contributions to glibc we need copyright assignment to
the FSF for the changes. I would suggest a future assignment for glibc.

If you are going to want to contribute to the GNU Toolchain as a whole
then I usually recommend a larger set of packages for copyright
future assignment. We can talk about that if you like.

This is much easier these days as digital processing is more straight
forward with the FSF these days.

Start here:
http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future

-- 
Cheers,
Carlos.