From: Roland McGrath <roland@hack.frob.com>
To: "Carlos O'Donell" <carlos@systemhalted.org>
Cc: libc-ports@sourceware.org
Subject: Re: [COMMITTED PATCH] add missing const in arm_gnu_pltexit signature
Date: Thu, 09 Aug 2012 23:00:00 -0000 [thread overview]
Message-ID: <20120809230036.1D12D2C0CE@topped-with-meat.com> (raw)
In-Reply-To: Carlos O'Donell's message of Thursday, 9 August 2012 18:56:22 -0400 <CADZpyiz2EoubHCpHDEeVuNrP0i8H3sXLQ-qFysOW9AXQBWTSMQ@mail.gmail.com>
> I did a quick scan of all the other targets and noticed something I
> thought was odd...
Not so odd, but you remind me that sotruss-lib.c needs the same treatment
the other audit stuff got to move machine-dependent bits into sysdeps files.
> Why do sh, sparc, mips, m68k, ia64, alpha use `const struct La_sh_regs
> *' for ARCH_PLTENTER_MEMBERS?
>
> Shouldn't that set of register be modifiable by the called audit function?
Yes, I think it should be modifiable and those signatures are wrong.
Clearly we'd be well-served by a test of an audit module with a pltenter
function that actually does something.
next prev parent reply other threads:[~2012-08-09 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 21:59 Roland McGrath
2012-08-09 22:56 ` Carlos O'Donell
2012-08-09 23:00 ` Roland McGrath [this message]
2012-08-09 23:30 ` Joseph S. Myers
2012-08-09 23:39 ` Roland McGrath
2012-08-10 9:02 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809230036.1D12D2C0CE@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=carlos@systemhalted.org \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).