From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: Carlos O'Donell <carlos@systemhalted.org>, <libc-ports@sourceware.org>
Subject: Re: [COMMITTED PATCH] add missing const in arm_gnu_pltexit signature
Date: Thu, 09 Aug 2012 23:30:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1208092327090.21255@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20120809230036.1D12D2C0CE@topped-with-meat.com>
On Thu, 9 Aug 2012, Roland McGrath wrote:
> > I did a quick scan of all the other targets and noticed something I
> > thought was odd...
>
> Not so odd, but you remind me that sotruss-lib.c needs the same treatment
> the other audit stuff got to move machine-dependent bits into sysdeps files.
As I noted in <http://sourceware.org/ml/libc-alpha/2012-07/msg00346.html>,
there is duplication between bits/link.h, dl-machine.h, ldsodefs.h,
tst-audit.h and sotruss-lib.c, and some of the architecture-specific
definitions are only because certain internal names are unnecessarily
different between architectures. I certainly don't think that each
architecture providing a sotruss-lib.c file will be a good end-point
regarding getting that information into sysdeps; it should be in a header
file included by a single sotruss-lib.c file instead.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-08-09 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 21:59 Roland McGrath
2012-08-09 22:56 ` Carlos O'Donell
2012-08-09 23:00 ` Roland McGrath
2012-08-09 23:30 ` Joseph S. Myers [this message]
2012-08-09 23:39 ` Roland McGrath
2012-08-10 9:02 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1208092327090.21255@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@systemhalted.org \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).