From: "Carlos O'Donell" <carlos@systemhalted.org>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-ports@sourceware.org
Subject: Re: [COMMITTED PATCH] add missing const in arm_gnu_pltexit signature
Date: Thu, 09 Aug 2012 22:56:00 -0000 [thread overview]
Message-ID: <CADZpyiz2EoubHCpHDEeVuNrP0i8H3sXLQ-qFysOW9AXQBWTSMQ@mail.gmail.com> (raw)
In-Reply-To: <20120808215850.048902C0ED@topped-with-meat.com>
On Wed, Aug 8, 2012 at 5:58 PM, Roland McGrath <roland@hack.frob.com> wrote:
> This fixes a 'discarded const' warning compiling dl-runtime.c, because
> the signature of the function pointer lacked the const that other machines
> have.
>
> Committed as obvious.
>
>
> Thanks,
> Roland
>
>
> ports/ChangeLog.arm
> * sysdeps/arm/ldsodefs.h (ARCH_PLTEXIT_MEMBERS): Use const on
> `struct La_arm_regs *' parameter.
>
> diff --git a/ports/sysdeps/arm/ldsodefs.h b/ports/sysdeps/arm/ldsodefs.h
> index aa323d3..73375b6 100644
> --- a/ports/sysdeps/arm/ldsodefs.h
> +++ b/ports/sysdeps/arm/ldsodefs.h
> @@ -1,5 +1,5 @@
> /* Run-time dynamic linker data structures for loaded ELF shared objects.
> - Copyright (C) 2005 Free Software Foundation, Inc.
> + Copyright (C) 2005-2012 Free Software Foundation, Inc.
> This file is part of the GNU C Library.
>
> The GNU C Library is free software; you can redistribute it and/or
> @@ -32,7 +32,7 @@ struct La_arm_retval;
>
> #define ARCH_PLTEXIT_MEMBERS \
> Elf32_Addr (*arm_gnu_pltexit) (Elf32_Sym *, unsigned int, uintptr_t *, \
> - uintptr_t *, struct La_arm_regs *, \
> + uintptr_t *, const struct La_arm_regs *, \
> struct La_arm_retval *, const char *)
>
> #include_next <ldsodefs.h>
I did a quick scan of all the other targets and noticed something I
thought was odd...
Why do sh, sparc, mips, m68k, ia64, alpha use `const struct La_sh_regs
*' for ARCH_PLTENTER_MEMBERS?
Shouldn't that set of register be modifiable by the called audit function?
Cheers,
Carlos.
next prev parent reply other threads:[~2012-08-09 22:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 21:59 Roland McGrath
2012-08-09 22:56 ` Carlos O'Donell [this message]
2012-08-09 23:00 ` Roland McGrath
2012-08-09 23:30 ` Joseph S. Myers
2012-08-09 23:39 ` Roland McGrath
2012-08-10 9:02 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADZpyiz2EoubHCpHDEeVuNrP0i8H3sXLQ-qFysOW9AXQBWTSMQ@mail.gmail.com \
--to=carlos@systemhalted.org \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).