From: Roland McGrath <roland@hack.frob.com>
To: Maxim Kuvyrkov <maxim@codesourcery.com>
Cc: Andrew Haley <aph@redhat.com>,
David Miller <davem@davemloft.net>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Richard Sandiford <rdsandiford@googlemail.com>,
<libc-ports@sourceware.org>,
GLIBC Devel <libc-alpha@sourceware.org>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH] Unify pthread_spin_[try]lock implementations.
Date: Wed, 15 Aug 2012 16:56:00 -0000 [thread overview]
Message-ID: <20120815165613.1F2972C10C@topped-with-meat.com> (raw)
In-Reply-To: Maxim Kuvyrkov's message of Thursday, 16 August 2012 04:52:39 +1200 <AFCB985E-C1C3-49FB-8267-003F6E9D30DB@codesourcery.com>
> This works at least with GCC 4.4 and GCC 4.8, albeit with a warning:
>
> ../ports/sysdeps/mips/nptl/pthread_spin_lock.c:19:2: warning: #include_next in primary source file [enabled by default]
> #include_next <nptl/pthread_spin_lock.c>
> ^
Right. We don't want that.
> Given that previous versions of GCC can, potentially, fail to compile
> this, I would rather use the "../../../../nptl/pthread_spin_lock.c"
> version. Any alternative suggestions?
Anything that depends on the location of the source file is a bad idea.
It will break if things get moved around, and perhaps nonobviously.
You could use <sysdeps/../nptl/foo.c> but it merits a comment about why
the more common and simple <nptl/foo.c> is not being used.
Thanks,
Roland
next prev parent reply other threads:[~2012-08-15 16:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 4:36 [PATCH 2/3, MIPS] Rewrite MIPS' pthread_spin_[try]lock using __atomic_* builtins Maxim Kuvyrkov
2012-06-28 23:10 ` Joseph S. Myers
2012-07-11 5:58 ` [PATCH] Unify pthread_spin_[try]lock implementations Maxim Kuvyrkov
2012-07-11 8:15 ` Roland McGrath
2012-07-11 8:25 ` David Miller
2012-07-11 8:44 ` Andrew Haley
2012-07-11 8:54 ` Maxim Kuvyrkov
2012-07-11 9:02 ` Andrew Haley
2012-07-11 9:05 ` Maxim Kuvyrkov
2012-07-11 11:22 ` Roland McGrath
2012-07-11 14:52 ` Chris Metcalf
2012-07-11 22:16 ` Maxim Kuvyrkov
2012-07-25 18:13 ` Roland McGrath
2012-07-25 19:04 ` Chris Metcalf
2012-07-25 20:22 ` Roland McGrath
2012-07-25 20:29 ` Chris Metcalf
2012-07-25 20:43 ` Roland McGrath
2012-08-15 3:17 ` Maxim Kuvyrkov
2012-08-15 16:27 ` Roland McGrath
2012-08-15 16:39 ` Maxim Kuvyrkov
2012-08-15 16:44 ` Roland McGrath
2012-08-15 16:53 ` Maxim Kuvyrkov
2012-08-15 16:56 ` Roland McGrath [this message]
2012-08-15 17:05 ` Maxim Kuvyrkov
2012-08-15 17:05 ` Jeff Law
2012-08-15 17:11 ` Roland McGrath
2012-08-15 17:24 ` Jeff Law
2012-08-15 16:40 ` Joseph S. Myers
2012-08-15 16:43 ` Carlos O'Donell
2012-08-15 22:00 ` Andreas Schwab
2012-08-16 10:21 ` Torvald Riegel
2012-08-16 12:40 ` Chris Metcalf
2012-08-22 23:16 ` Maxim Kuvyrkov
2012-07-11 8:26 ` Maxim Kuvyrkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815165613.1F2972C10C@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=aph@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=maxim@codesourcery.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).