* [PATCH 2/3 elf] Add MicroBlaze support to elf.h @ 2012-11-29 5:29 David Holsgrove 2012-11-29 6:04 ` [PATCH] Adding MicroBlaze support to elf/elf.h David Holsgrove 2012-11-29 7:16 ` [PATCH 2/3 elf] Add MicroBlaze support to elf.h Andreas Jaeger 0 siblings, 2 replies; 10+ messages in thread From: David Holsgrove @ 2012-11-29 5:29 UTC (permalink / raw) To: libc-alpha, libc-ports Cc: John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala [-- Attachment #1: Type: text/plain, Size: 153 bytes --] Add MicroBlaze relocations to elf/elf.h 2012-11-29 David Holsgrove <david.holsgrove@xilinx.com> * elf/elf.h: Add support for MicroBlaze arch [-- Attachment #2: 0002-Adding-MicroBlaze-support-to-elf-elf.h.patch --] [-- Type: application/octet-stream, Size: 2034 bytes --] From 02a0759b648b6aed4538cd0cde88babf5468585a Mon Sep 17 00:00:00 2001 From: David Holsgrove <david.holsgrove@petalogix.com> Date: Wed, 4 Jan 2012 13:56:48 +1000 Subject: [PATCH] Adding MicroBlaze support to elf/elf.h Signed-off-by: David Holsgrove <david.holsgrove@petalogix.com> --- elf/elf.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/elf/elf.h b/elf/elf.h index b07e6ad..6a4a4cc 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -259,6 +259,8 @@ typedef struct chances of collision with official or non-GNU unofficial values. */ #define EM_ALPHA 0x9026 +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ +#define EM_MICROBLAZE 0xbaab /* Legal values for e_version (version). */ @@ -2847,6 +2849,37 @@ typedef Elf32_Addr Elf32_Conflict; #define R_M32R_GOTOFF_LO 64 /* Low 16 bit offset to GOT */ #define R_M32R_NUM 256 /* Keep this the last entry. */ +/* microblaze relocations */ +#define R_MICROBLAZE_NONE 0 +#define R_MICROBLAZE_32 1 +#define R_MICROBLAZE_32_PCREL 2 +#define R_MICROBLAZE_64_PCREL 3 +#define R_MICROBLAZE_32_PCREL_LO 4 +#define R_MICROBLAZE_64 5 +#define R_MICROBLAZE_32_LO 6 +#define R_MICROBLAZE_SRO32 7 +#define R_MICROBLAZE_SRW32 8 +#define R_MICROBLAZE_64_NONE 9 +#define R_MICROBLAZE_32_SYM_OP_SYM 10 +#define R_MICROBLAZE_GNU_VTINHERIT 11 +#define R_MICROBLAZE_GNU_VTENTRY 12 +#define R_MICROBLAZE_GOTPC_64 13 +#define R_MICROBLAZE_GOT_64 14 +#define R_MICROBLAZE_PLT_64 15 +#define R_MICROBLAZE_REL 16 +#define R_MICROBLAZE_JUMP_SLOT 17 +#define R_MICROBLAZE_GLOB_DAT 18 +#define R_MICROBLAZE_GOTOFF_64 19 +#define R_MICROBLAZE_GOTOFF_32 20 +#define R_MICROBLAZE_COPY 21 +#define R_MICROBLAZE_TLS 22 +#define R_MICROBLAZE_TLSGD 23 +#define R_MICROBLAZE_TLSLD 24 +#define R_MICROBLAZE_TLSDTPMOD32 25 +#define R_MICROBLAZE_TLSDTPREL32 26 +#define R_MICROBLAZE_TLSDTPREL64 27 +#define R_MICROBLAZE_TLSGOTTPREL32 28 +#define R_MICROBLAZE_TLSTPREL32 29 /* TILEPro relocations. */ #define R_TILEPRO_NONE 0 /* No reloc */ -- 1.7.9.5 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Adding MicroBlaze support to elf/elf.h 2012-11-29 5:29 [PATCH 2/3 elf] Add MicroBlaze support to elf.h David Holsgrove @ 2012-11-29 6:04 ` David Holsgrove 2012-11-29 7:16 ` [PATCH 2/3 elf] Add MicroBlaze support to elf.h Andreas Jaeger 1 sibling, 0 replies; 10+ messages in thread From: David Holsgrove @ 2012-11-29 6:04 UTC (permalink / raw) To: libc-alpha, libc-ports Cc: john.williams, edgar.iglesias, vinodk, tshui, vidhum, nmekala From: David Holsgrove <david.holsgrove@petalogix.com> Signed-off-by: David Holsgrove <david.holsgrove@petalogix.com> --- elf/elf.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/elf/elf.h b/elf/elf.h index b07e6ad..6a4a4cc 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -259,6 +259,8 @@ typedef struct chances of collision with official or non-GNU unofficial values. */ #define EM_ALPHA 0x9026 +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ +#define EM_MICROBLAZE 0xbaab /* Legal values for e_version (version). */ @@ -2847,6 +2849,37 @@ typedef Elf32_Addr Elf32_Conflict; #define R_M32R_GOTOFF_LO 64 /* Low 16 bit offset to GOT */ #define R_M32R_NUM 256 /* Keep this the last entry. */ +/* microblaze relocations */ +#define R_MICROBLAZE_NONE 0 +#define R_MICROBLAZE_32 1 +#define R_MICROBLAZE_32_PCREL 2 +#define R_MICROBLAZE_64_PCREL 3 +#define R_MICROBLAZE_32_PCREL_LO 4 +#define R_MICROBLAZE_64 5 +#define R_MICROBLAZE_32_LO 6 +#define R_MICROBLAZE_SRO32 7 +#define R_MICROBLAZE_SRW32 8 +#define R_MICROBLAZE_64_NONE 9 +#define R_MICROBLAZE_32_SYM_OP_SYM 10 +#define R_MICROBLAZE_GNU_VTINHERIT 11 +#define R_MICROBLAZE_GNU_VTENTRY 12 +#define R_MICROBLAZE_GOTPC_64 13 +#define R_MICROBLAZE_GOT_64 14 +#define R_MICROBLAZE_PLT_64 15 +#define R_MICROBLAZE_REL 16 +#define R_MICROBLAZE_JUMP_SLOT 17 +#define R_MICROBLAZE_GLOB_DAT 18 +#define R_MICROBLAZE_GOTOFF_64 19 +#define R_MICROBLAZE_GOTOFF_32 20 +#define R_MICROBLAZE_COPY 21 +#define R_MICROBLAZE_TLS 22 +#define R_MICROBLAZE_TLSGD 23 +#define R_MICROBLAZE_TLSLD 24 +#define R_MICROBLAZE_TLSDTPMOD32 25 +#define R_MICROBLAZE_TLSDTPREL32 26 +#define R_MICROBLAZE_TLSDTPREL64 27 +#define R_MICROBLAZE_TLSGOTTPREL32 28 +#define R_MICROBLAZE_TLSTPREL32 29 /* TILEPro relocations. */ #define R_TILEPRO_NONE 0 /* No reloc */ -- 1.7.9.5 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 5:29 [PATCH 2/3 elf] Add MicroBlaze support to elf.h David Holsgrove 2012-11-29 6:04 ` [PATCH] Adding MicroBlaze support to elf/elf.h David Holsgrove @ 2012-11-29 7:16 ` Andreas Jaeger 2012-11-29 7:58 ` Mike Frysinger 2012-11-29 8:03 ` David Holsgrove 1 sibling, 2 replies; 10+ messages in thread From: Andreas Jaeger @ 2012-11-29 7:16 UTC (permalink / raw) To: David Holsgrove Cc: libc-alpha, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala On 11/29/2012 06:28 AM, David Holsgrove wrote: > d MicroBlaze relocations to elf/elf.h > > 2012-11-29 David Holsgrove<david.holsgrove@xilinx.com> > > * elf/elf.h: Add support for MicroBlaze arch > > > 0002-Adding-MicroBlaze-support-to-elf-elf.h.patch > David, thanks for your patch. Could you please review the Contribution checklist at http://sourceware.org/glibc/wiki/Contribution%20checklist? Your patch misses a valid ChangeLog entry and that's needed for such changes. > From 02a0759b648b6aed4538cd0cde88babf5468585a Mon Sep 17 00:00:00 2001 > From: David Holsgrove<david.holsgrove@petalogix.com> > Date: Wed, 4 Jan 2012 13:56:48 +1000 > Subject: [PATCH] Adding MicroBlaze support to elf/elf.h > > Signed-off-by: David Holsgrove<david.holsgrove@petalogix.com> > --- > elf/elf.h | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/elf/elf.h b/elf/elf.h > index b07e6ad..6a4a4cc 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -259,6 +259,8 @@ typedef struct > chances of collision with official or non-GNU unofficial values. */ > > #define EM_ALPHA 0x9026 > +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ > +#define EM_MICROBLAZE 0xbaab Are any of these official values? The comment above asks for hig numbers and 0xbd is not height. > > /* Legal values for e_version (version). */ > > @@ -2847,6 +2849,37 @@ typedef Elf32_Addr Elf32_Conflict; > #define R_M32R_GOTOFF_LO 64 /* Low 16 bit offset to GOT */ > #define R_M32R_NUM 256 /* Keep this the last entry. */ > > +/* microblaze relocations */ > +#define R_MICROBLAZE_NONE 0 I suggest to be consistent with the writing of the name - so is it microblaze or MicroBlaze? > +#define R_MICROBLAZE_32 1 > +#define R_MICROBLAZE_32_PCREL 2 > +#define R_MICROBLAZE_64_PCREL 3 > +#define R_MICROBLAZE_32_PCREL_LO 4 > +#define R_MICROBLAZE_64 5 > +#define R_MICROBLAZE_32_LO 6 > +#define R_MICROBLAZE_SRO32 7 > +#define R_MICROBLAZE_SRW32 8 > [...] Please add comments for all of them, Thanks, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 7:16 ` [PATCH 2/3 elf] Add MicroBlaze support to elf.h Andreas Jaeger @ 2012-11-29 7:58 ` Mike Frysinger 2012-11-29 8:04 ` Andreas Jaeger 2012-11-29 8:03 ` David Holsgrove 1 sibling, 1 reply; 10+ messages in thread From: Mike Frysinger @ 2012-11-29 7:58 UTC (permalink / raw) To: libc-alpha Cc: Andreas Jaeger, David Holsgrove, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala [-- Attachment #1: Type: Text/Plain, Size: 468 bytes --] On Thursday 29 November 2012 02:16:22 Andreas Jaeger wrote: > On 11/29/2012 06:28 AM, David Holsgrove wrote: > > +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ > > +#define EM_MICROBLAZE 0xbaab > > Are any of these official values? The comment above asks for hig numbers > and 0xbd is not height. the first one is, but should be renamed. from binutils: #define EM_MICROBLAZE 189 /* Xilinx MicroBlaze 32-bit RISC soft processor core */ -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 7:58 ` Mike Frysinger @ 2012-11-29 8:04 ` Andreas Jaeger 2012-11-29 8:23 ` David Holsgrove 2012-11-29 16:06 ` Joseph S. Myers 0 siblings, 2 replies; 10+ messages in thread From: Andreas Jaeger @ 2012-11-29 8:04 UTC (permalink / raw) To: Mike Frysinger Cc: libc-alpha, David Holsgrove, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala On 11/29/2012 08:58 AM, Mike Frysinger wrote: > On Thursday 29 November 2012 02:16:22 Andreas Jaeger wrote: >> On 11/29/2012 06:28 AM, David Holsgrove wrote: >>> +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ >>> +#define EM_MICROBLAZE 0xbaab >> >> Are any of these official values? The comment above asks for hig numbers >> and 0xbd is not height. > > the first one is, but should be renamed. from binutils: > #define EM_MICROBLAZE 189 /* Xilinx MicroBlaze 32-bit RISC soft processor core */ In that case, it should be sorted at the proper place - directly after EM_TILEPRO. David, we've just frozen glibc for development, these kind of patches are too late for glibc 2.17. Please update them and they will get properly reviewed and added once 2.17 is released. Btw. do you have copyright announcement with the FSF? Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 8:04 ` Andreas Jaeger @ 2012-11-29 8:23 ` David Holsgrove 2012-11-29 16:06 ` Joseph S. Myers 1 sibling, 0 replies; 10+ messages in thread From: David Holsgrove @ 2012-11-29 8:23 UTC (permalink / raw) To: Andreas Jaeger, Mike Frysinger Cc: libc-alpha, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala Hi Andreas, > -----Original Message----- > From: Andreas Jaeger [mailto:aj@suse.com] > Sent: Thursday, 29 November 2012 6:05 pm > To: Mike Frysinger > Cc: libc-alpha@sourceware.org; David Holsgrove; libc-ports@sourceware.org; > John Williams; Edgar E. Iglesias; Vinod Kathail; Tom Shui; Vidhumouli Hunsigida; > Nagaraju Mekala > Subject: Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h > > On 11/29/2012 08:58 AM, Mike Frysinger wrote: > > On Thursday 29 November 2012 02:16:22 Andreas Jaeger wrote: > >> On 11/29/2012 06:28 AM, David Holsgrove wrote: > >>> +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ > >>> +#define EM_MICROBLAZE 0xbaab > >> > >> Are any of these official values? The comment above asks for hig numbers > >> and 0xbd is not height. > > > > the first one is, but should be renamed. from binutils: > > #define EM_MICROBLAZE 189 /* Xilinx MicroBlaze 32-bit RISC soft processor > core */ > > In that case, it should be sorted at the proper place - directly after > EM_TILEPRO. > > David, we've just frozen glibc for development, these kind of patches > are too late for glibc 2.17. Please update them and they will get > properly reviewed and added once 2.17 is released. > Thanks for the heads up, does this apply to commits self-contained to libc-ports also? (can't hurt to ask :-) ) > Btw. do you have copyright announcement with the FSF? Yes, Xilinx has copyright assignments with FSF, completed in January 2010. David > Andreas > -- > Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) > GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 8:04 ` Andreas Jaeger 2012-11-29 8:23 ` David Holsgrove @ 2012-11-29 16:06 ` Joseph S. Myers 2012-11-29 16:11 ` Carlos O'Donell 1 sibling, 1 reply; 10+ messages in thread From: Joseph S. Myers @ 2012-11-29 16:06 UTC (permalink / raw) To: Andreas Jaeger Cc: Mike Frysinger, libc-alpha, David Holsgrove, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala On Thu, 29 Nov 2012, Andreas Jaeger wrote: > David, we've just frozen glibc for development, these kind of patches are too > late for glibc 2.17. Please update them and they will get properly reviewed > and added once 2.17 is released. There's no risk of such patches requiring any updates to existing architectures, or breaking them, or requiring any updates to message translations, so I see no reason for them to be affected by the freeze. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 16:06 ` Joseph S. Myers @ 2012-11-29 16:11 ` Carlos O'Donell 2012-11-29 16:20 ` Joseph S. Myers 0 siblings, 1 reply; 10+ messages in thread From: Carlos O'Donell @ 2012-11-29 16:11 UTC (permalink / raw) To: Joseph S. Myers Cc: Andreas Jaeger, Mike Frysinger, libc-alpha, David Holsgrove, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala On Thu, Nov 29, 2012 at 11:05 AM, Joseph S. Myers <joseph@codesourcery.com> wrote: > On Thu, 29 Nov 2012, Andreas Jaeger wrote: > >> David, we've just frozen glibc for development, these kind of patches are too >> late for glibc 2.17. Please update them and they will get properly reviewed >> and added once 2.17 is released. > > There's no risk of such patches requiring any updates to existing > architectures, or breaking them, or requiring any updates to message > translations, so I see no reason for them to be affected by the freeze. This is the second time we've had this kind of discussion. However, you did not reply to my comments last time[1]. I will say them again for the record. There are both direct and indirect benefits here. The direct benefit is that it's one less patch I have to review going onto trunk. The indirect benefit is that we get the community into the habit and discipline of setting aside trivial changes to focus on stabilizing trunk. Does that make sense? I don't mind if this patch gets checked into trunk, but please work with David to ensure that it goes in without error. Cheers, Carlos. [1] http://sourceware.org/ml/libc-alpha/2012-06/msg00267.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 16:11 ` Carlos O'Donell @ 2012-11-29 16:20 ` Joseph S. Myers 0 siblings, 0 replies; 10+ messages in thread From: Joseph S. Myers @ 2012-11-29 16:20 UTC (permalink / raw) To: Carlos O'Donell Cc: Andreas Jaeger, Mike Frysinger, libc-alpha, David Holsgrove, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala On Thu, 29 Nov 2012, Carlos O'Donell wrote: > The indirect benefit is that we get the community into the > habit and discipline of setting aside trivial changes to > focus on stabilizing trunk. The freeze is meant to be our servant, not our master. A freeze causes harm by preventing useful improvements getting in, being used as a basis for other improvements and becoming available to users of releases, and should be strictly limited so that it only operates to the extent, and for the time, necessary to get out a release maximally useful to a wide range of users on a range of architectures. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/3 elf] Add MicroBlaze support to elf.h 2012-11-29 7:16 ` [PATCH 2/3 elf] Add MicroBlaze support to elf.h Andreas Jaeger 2012-11-29 7:58 ` Mike Frysinger @ 2012-11-29 8:03 ` David Holsgrove 1 sibling, 0 replies; 10+ messages in thread From: David Holsgrove @ 2012-11-29 8:03 UTC (permalink / raw) To: Andreas Jaeger Cc: libc-alpha, libc-ports, John Williams, Edgar E. Iglesias, Vinod Kathail, Tom Shui, Vidhumouli Hunsigida, Nagaraju Mekala Hi Andreas, > -----Original Message----- > From: Andreas Jaeger [mailto:aj@suse.com] > Sent: Thursday, 29 November 2012 5:16 pm > To: David Holsgrove > Cc: libc-alpha@sourceware.org; libc-ports@sourceware.org; John Williams; Edgar > E. Iglesias; Vinod Kathail; Tom Shui; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h > > On 11/29/2012 06:28 AM, David Holsgrove wrote: > > d MicroBlaze relocations to elf/elf.h > > > > 2012-11-29 David Holsgrove<david.holsgrove@xilinx.com> > > > > * elf/elf.h: Add support for MicroBlaze arch > > > > > > 0002-Adding-MicroBlaze-support-to-elf-elf.h.patch > > > > David, thanks for your patch. Could you please review the Contribution > checklist at http://sourceware.org/glibc/wiki/Contribution%20checklist? > > Your patch misses a valid ChangeLog entry and that's needed for such > changes. Thanks, will update in next version. > > > From 02a0759b648b6aed4538cd0cde88babf5468585a Mon Sep 17 00:00:00 2001 > > From: David Holsgrove<david.holsgrove@petalogix.com> > > Date: Wed, 4 Jan 2012 13:56:48 +1000 > > Subject: [PATCH] Adding MicroBlaze support to elf/elf.h > > > > Signed-off-by: David Holsgrove<david.holsgrove@petalogix.com> > > --- > > elf/elf.h | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/elf/elf.h b/elf/elf.h > > index b07e6ad..6a4a4cc 100644 > > --- a/elf/elf.h > > +++ b/elf/elf.h > > @@ -259,6 +259,8 @@ typedef struct > > chances of collision with official or non-GNU unofficial values. */ > > > > #define EM_ALPHA 0x9026 > > +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ > > +#define EM_MICROBLAZE 0xbaab > > Are any of these official values? The comment above asks for hig numbers > and 0xbd is not height. > Yes they are, but could be renamed to better match upstream binutils. I'll revise in this patch for elf.h and also my patch to libc-ports thanks. > > > > /* Legal values for e_version (version). */ > > > > @@ -2847,6 +2849,37 @@ typedef Elf32_Addr Elf32_Conflict; > > #define R_M32R_GOTOFF_LO 64 /* Low 16 bit offset to GOT */ > > #define R_M32R_NUM 256 /* Keep this the last entry. */ > > > > +/* microblaze relocations */ > > +#define R_MICROBLAZE_NONE 0 > > I suggest to be consistent with the writing of the name - so is it > microblaze or MicroBlaze? MicroBlaze :-) Comment updated. > > > +#define R_MICROBLAZE_32 1 > > +#define R_MICROBLAZE_32_PCREL 2 > > +#define R_MICROBLAZE_64_PCREL 3 > > +#define R_MICROBLAZE_32_PCREL_LO 4 > > +#define R_MICROBLAZE_64 5 > > +#define R_MICROBLAZE_32_LO 6 > > +#define R_MICROBLAZE_SRO32 7 > > +#define R_MICROBLAZE_SRW32 8 > > [...] > > Please add comments for all of them, > Thanks for the review, I'll send v2 of my patch shortly. regards, David > Thanks, > Andreas > -- > Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) > GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-11-29 16:20 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-11-29 5:29 [PATCH 2/3 elf] Add MicroBlaze support to elf.h David Holsgrove 2012-11-29 6:04 ` [PATCH] Adding MicroBlaze support to elf/elf.h David Holsgrove 2012-11-29 7:16 ` [PATCH 2/3 elf] Add MicroBlaze support to elf.h Andreas Jaeger 2012-11-29 7:58 ` Mike Frysinger 2012-11-29 8:04 ` Andreas Jaeger 2012-11-29 8:23 ` David Holsgrove 2012-11-29 16:06 ` Joseph S. Myers 2012-11-29 16:11 ` Carlos O'Donell 2012-11-29 16:20 ` Joseph S. Myers 2012-11-29 8:03 ` David Holsgrove
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).