From: Chris Metcalf <cmetcalf@tilera.com>
To: Chung-Lin Tang <cltang@codesourcery.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
Andrew Pinski <pinskia@gmail.com>,
Marcus Shawcroft <marcus.shawcroft@linaro.org>
Subject: Re: struct statfs/statfs64 in linux-generic
Date: Mon, 18 Nov 2013 23:39:00 -0000 [thread overview]
Message-ID: <528A5A89.10507@tilera.com> (raw)
In-Reply-To: <5285CFA6.8020700@codesourcery.com>
On 11/15/2013 2:39 AM, Chung-Lin Tang wrote:
> Yes, that works for nios2. Appears that struct stat/stat64 in
> bits/stat.h doesn't have the struct alignment attributes either.
> Updated patch attached.
>
> Chung-Lin
>
> 2013-11-13 Chung-Lin Tang <cltang@codesourcery.com>
>
> ports/
> * sysdeps/unix/sysv/linux/generic/bits/stat.h (__field64): Use
> __alignof__(type64) in alignment attribute instead of 8.
> * sysdeps/unix/sysv/linux/generic/bits/statfs.h (__field64): Use
> __alignof__(type64) in alignment attribute instead of 8.
> (struct statfs): Remove alignment attribute.
> (struct statfs64): Likewise.
The patch works fine for tilegx, so I think it should be OK to commit.
Marcus, did you want to verify that it works OK for AArch64 first?
My guess it that it should be OK for you.
Chung-Lin Tang, do you have commit access, or would you like me to
commit the change for you?
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2013-11-18 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 7:18 Chung-Lin Tang
2013-11-04 8:19 ` Andrew Pinski
2013-11-05 4:23 ` Chung-Lin Tang
2013-11-07 19:55 ` Chris Metcalf
2013-11-10 8:24 ` Chung-Lin Tang
2013-11-11 17:48 ` Joseph S. Myers
2013-11-13 8:17 ` Chung-Lin Tang
2013-11-13 12:59 ` Joseph S. Myers
2013-11-14 4:34 ` Chung-Lin Tang
2013-11-14 13:36 ` Joseph S. Myers
2013-11-14 18:28 ` Chris Metcalf
2013-11-15 7:39 ` Chung-Lin Tang
2013-11-18 23:39 ` Chris Metcalf [this message]
2013-11-19 13:50 ` Chung-Lin Tang
2013-11-22 2:43 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A5A89.10507@tilera.com \
--to=cmetcalf@tilera.com \
--cc=cltang@codesourcery.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=marcus.shawcroft@linaro.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).