From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Richard Henderson <rth@twiddle.net>
Cc: Roland McGrath <roland@hack.frob.com>, <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-memchr] ARM: Make armv6t2 memchr implementation usable without Thumb.
Date: Tue, 12 Mar 2013 15:58:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1303121557190.450@digraph.polyomino.org.uk> (raw)
In-Reply-To: <513EC685.1020803@twiddle.net>
On Mon, 11 Mar 2013, Richard Henderson wrote:
> On 2013-03-11 17:30, Joseph S. Myers wrote:
> > On Mon, 11 Mar 2013, Roland McGrath wrote:
> >
> > > This changes the memchr implementation to be usable without Thumb.
> >
> > I'm not clear on how the register allocation changes relate to making this
> > implementation usable without Thumb.
> >
>
> This re ldrd. ARM mode requires r2 = r + 1, and r even.
> Thumb2 allows arbitrary r2.
Thanks. In that case I think the register allocation part of the patch
should be separated from the cbz/cbnz part to make each change easier to
review.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-03-12 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:31 Roland McGrath
2013-03-12 0:30 ` Joseph S. Myers
2013-03-12 6:09 ` Richard Henderson
2013-03-12 15:58 ` Joseph S. Myers [this message]
2013-03-12 17:07 ` [PATCH 1/2 roland/arm-memchr] ARM: Change register allocation in armv6t2 memchr implementation Roland McGrath
2013-03-12 23:20 ` Joseph S. Myers
2013-03-13 0:06 ` Roland McGrath
2013-03-12 17:08 ` [PATCH 2/2 roland/arm-memchr] ARM: Make armv6t2 memchr implementation usable without Thumb Roland McGrath
2013-03-12 23:21 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1303121557190.450@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).