From: Tom Tromey <tromey@adacore.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>,
Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>,
libstdc++@gcc.gnu.org
Subject: Re: [committed] libstdc++: Add GDB printers for <chrono> types
Date: Wed, 27 Sep 2023 11:24:13 -0600 [thread overview]
Message-ID: <874jjf4jia.fsf@tromey.com> (raw)
In-Reply-To: <CACb0b4kf33Y518=X6LFTi=i29dp2FvQT1JjPh+8j39Wn9iK3zw@mail.gmail.com> (Jonathan Wakely's message of "Wed, 27 Sep 2023 17:15:07 +0100")
>> I have fixes for most of the issues that are worth fixing (I didn't
>> bother with line lengths -- FWIW in gdb we just run 'black' and don't
>> worry about these details),
Jonathan> I used autopep8 and committed the result as
Jonathan> e08559271b2d797f658579ac8610dbf5e58bcfd8 so the line lengths
Jonathan> should be OK now.
Yeah, my patches are on top of that, but flake8 still complains, and I
still see lines > 79 characters. However maybe flake8 isn't the checker
you want to use, or maybe you have something set up for a different line
length?
Jonathan> So the fix is to just change the string to '{} {}' which I've pushed
Jonathan> as 1fab05a885a308c19cf42b72fd36805ddf27fdc8 now (also attached).
Thank you.
Tom
next prev parent reply other threads:[~2023-09-27 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 23:38 Jonathan Wakely
2023-09-27 15:37 ` Tom Tromey
2023-09-27 16:15 ` Jonathan Wakely
2023-09-27 17:24 ` Tom Tromey [this message]
2023-09-27 19:57 ` Jonathan Wakely
2023-09-28 7:23 ` Jonathan Wakely
2023-09-28 17:37 ` Tom Tromey
2023-09-28 18:47 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jjf4jia.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).