public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Jonathan Wakely <>
Cc: Tom Tromey <>,
	 Jonathan Wakely <>,
	Jonathan Wakely via Gcc-patches <>,
	 "libstdc++" <>
Subject: Re: [committed] libstdc++: Add GDB printers for <chrono> types
Date: Thu, 28 Sep 2023 11:37:27 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Jonathan Wakely's message of "Thu, 28 Sep 2023 08:23:16 +0100")

Jonathan> The changes made by black seem reasonable, though I prefer it
Jonathan> with -S to disable string-normalization. It also needs an
Jonathan> option to use 79 as the maximum line length.

I've got some patches I'm about to send.

I made a pyproject.toml to auto-configure black (and isort), and this
works fine, but it also makes a bunch of edits.  So I'd rather send that
separately, after the current batch of patches is handled.

flake8 still isn't really happy, I guess because there are strings that
cause lines over 79, and black doesn't split those.  But meh, maybe
suppressing some flake8 errors is the way to go.


  reply	other threads:[~2023-09-28 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 23:38 Jonathan Wakely
2023-09-27 15:37 ` Tom Tromey
2023-09-27 16:15   ` Jonathan Wakely
2023-09-27 17:24     ` Tom Tromey
2023-09-27 19:57       ` Jonathan Wakely
2023-09-28  7:23         ` Jonathan Wakely
2023-09-28 17:37           ` Tom Tromey [this message]
2023-09-28 18:47             ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).