public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Tom Tromey <tromey@adacore.com>,
	 Jonathan Wakely <jwakely@redhat.com>,
	Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>,
	 "libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Add GDB printers for <chrono> types
Date: Thu, 28 Sep 2023 11:37:27 -0600	[thread overview]
Message-ID: <87r0mi2o88.fsf@tromey.com> (raw)
In-Reply-To: <CAH6eHdRMz=bqCgQyfk+4T1h1WuyWMm8Xv23XgKCJrSBWQ9ghkw@mail.gmail.com> (Jonathan Wakely's message of "Thu, 28 Sep 2023 08:23:16 +0100")

Jonathan> The changes made by black seem reasonable, though I prefer it
Jonathan> with -S to disable string-normalization. It also needs an
Jonathan> option to use 79 as the maximum line length.

I've got some patches I'm about to send.

I made a pyproject.toml to auto-configure black (and isort), and this
works fine, but it also makes a bunch of edits.  So I'd rather send that
separately, after the current batch of patches is handled.

flake8 still isn't really happy, I guess because there are strings that
cause lines over 79, and black doesn't split those.  But meh, maybe
suppressing some flake8 errors is the way to go.

Tom

  reply	other threads:[~2023-09-28 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 23:38 Jonathan Wakely
2023-09-27 15:37 ` Tom Tromey
2023-09-27 16:15   ` Jonathan Wakely
2023-09-27 17:24     ` Tom Tromey
2023-09-27 19:57       ` Jonathan Wakely
2023-09-28  7:23         ` Jonathan Wakely
2023-09-28 17:37           ` Tom Tromey [this message]
2023-09-28 18:47             ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0mi2o88.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely.gcc@gmail.com \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).