From: Tom Tromey <tromey@adacore.com>
To: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: libstdc++@gcc.gnu.org, Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [committed] libstdc++: Add GDB printers for <chrono> types
Date: Wed, 27 Sep 2023 09:37:31 -0600 [thread overview]
Message-ID: <878r8r4og4.fsf@tromey.com> (raw)
In-Reply-To: <20221222233804.772229-1-jwakely@redhat.com> (Jonathan Wakely via Gcc-patches's message of "Thu, 22 Dec 2022 23:38:04 +0000")
>>>>> Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
Replying to a quite old email...
I ran a Python linter on the libstdc++ pretty-printers.
I have fixes for most of the issues that are worth fixing (I didn't
bother with line lengths -- FWIW in gdb we just run 'black' and don't
worry about these details), but the patch I'm replying to had a problem
that I didn't know how to fix:
> +class StdChronoTimeZoneRulePrinter:
[...]
> + if kind == 0: # DayOfMonth
> + start = '{} {}{}'.format(month, ordinal_day)
flake8 points out that this call to format has three placeholders but
only two arguments.
Tom
next prev parent reply other threads:[~2023-09-27 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 23:38 Jonathan Wakely
2023-09-27 15:37 ` Tom Tromey [this message]
2023-09-27 16:15 ` Jonathan Wakely
2023-09-27 17:24 ` Tom Tromey
2023-09-27 19:57 ` Jonathan Wakely
2023-09-28 7:23 ` Jonathan Wakely
2023-09-28 17:37 ` Tom Tromey
2023-09-28 18:47 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r8r4og4.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).