From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [committed] libstdc++: Add GDB printers for <chrono> types
Date: Wed, 27 Sep 2023 20:57:13 +0100 [thread overview]
Message-ID: <CAH6eHdS2YPNdTu5svVHLGL-68LMYWwtc2AYNXzJu7MYOWKLnkw@mail.gmail.com> (raw)
In-Reply-To: <874jjf4jia.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Wed, 27 Sept 2023, 18:25 Tom Tromey via Libstdc++, <libstdc++@gcc.gnu.org>
wrote:
> >> I have fixes for most of the issues that are worth fixing (I didn't
> >> bother with line lengths -- FWIW in gdb we just run 'black' and don't
> >> worry about these details),
>
> Jonathan> I used autopep8 and committed the result as
> Jonathan> e08559271b2d797f658579ac8610dbf5e58bcfd8 so the line lengths
> Jonathan> should be OK now.
>
> Yeah, my patches are on top of that, but flake8 still complains, and I
> still see lines > 79 characters. However maybe flake8 isn't the checker
> you want to use, or maybe you have something set up for a different line
> length?
>
I don't think I have anything set up for python formatting at all, I just
committed whatever autopep8 did with its default settings.
If that's suboptimal, we can consider other tools, if they're reliable and
easy to run.
> Jonathan> So the fix is to just change the string to '{} {}' which I've
> pushed
> Jonathan> as 1fab05a885a308c19cf42b72fd36805ddf27fdc8 now (also attached).
>
> Thank you.
>
> Tom
>
next prev parent reply other threads:[~2023-09-27 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 23:38 Jonathan Wakely
2023-09-27 15:37 ` Tom Tromey
2023-09-27 16:15 ` Jonathan Wakely
2023-09-27 17:24 ` Tom Tromey
2023-09-27 19:57 ` Jonathan Wakely [this message]
2023-09-28 7:23 ` Jonathan Wakely
2023-09-28 17:37 ` Tom Tromey
2023-09-28 18:47 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdS2YPNdTu5svVHLGL-68LMYWwtc2AYNXzJu7MYOWKLnkw@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).