From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: testsuite: test symlnks ifdef _GLIBCXX_HAVE_SYMLINK
Date: Thu, 23 Jun 2022 13:37:56 +0100 [thread overview]
Message-ID: <CACb0b4=TOy1QEhPUGjoTvbZZFP4K8NpRMYHsJd9DDhNWwf3d-g@mail.gmail.com> (raw)
In-Reply-To: <orsfnv36c0.fsf@lxoliva.fsfla.org>
On Thu, 23 Jun 2022 at 13:36, Alexandre Oliva <oliva@adacore.com> wrote:
>
> On Jun 23, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> > Could this new arg be given a default value, so every caller doesn't
> > have to pass "" to it?
>
> > proc v3_check_preprocessor_condition { name cond {inc ""} } {
>
> Oh, nice, I didn't know about this convenient notation for default args
> in tcl, and the one I knew about I found too cumbersome. Thanks for the
> tip, I put it in the patch below.
>
> > #ifndef _GLIBCXX_HAVE_SYMLINK
>
> And this too.
>
> > And if the definition of NO_SYMLINKS gets more complicated in future
> > (e.g. we add something like && !defined __foo__) then using
> > NO_SYMLINKS in the dg proc will keep them in sync.
>
> 'zactly my thinking.
>
>
> Here's what I'm testing (same way). Ok to install if it passes?
Yes please, thanks for iterating to get this here.
next prev parent reply other threads:[~2022-06-23 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:13 Alexandre Oliva
2022-06-22 9:25 ` Jonathan Wakely
2022-06-22 10:42 ` Jonathan Wakely
2022-06-23 3:41 ` Alexandre Oliva
2022-06-23 10:53 ` Alexandre Oliva
2022-06-23 11:39 ` Jonathan Wakely
2022-06-23 11:02 ` Alexandre Oliva
2022-06-23 11:28 ` Jonathan Wakely
2022-06-23 11:29 ` Jonathan Wakely
2022-06-23 12:35 ` Alexandre Oliva
2022-06-23 12:37 ` Jonathan Wakely [this message]
2022-06-24 2:32 ` Alexandre Oliva
2022-06-27 13:29 ` Alexandre Oliva
2022-06-27 13:36 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=TOy1QEhPUGjoTvbZZFP4K8NpRMYHsJd9DDhNWwf3d-g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).