From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: testsuite: test symlnks ifdef _GLIBCXX_HAVE_SYMLINK
Date: Wed, 22 Jun 2022 10:25:37 +0100 [thread overview]
Message-ID: <CACb0b4=kLa=HcDLd26_1FhX2Uz5Nr5wut3r34kbM-XWcQEuKXw@mail.gmail.com> (raw)
In-Reply-To: <orr13h9qes.fsf@lxoliva.fsfla.org>
On Wed, 22 Jun 2022 at 07:14, Alexandre Oliva via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
>
> Several filesystem tests expect to be able to create symlinks even
> when !defined (_GLIBCXX_HAVE_SYMLINK), and fail predictably, reducing
> the amount of testing of other filesystem features.
>
> They are already skipped for mingw targets. I've extended the
> skipping to other targets in which _GLIBCXX_HAVE_SYMLINK is
> undefined.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6. Ok to install?
OK.
I'd like to clean this up so the tests don't rely on the "internal"
HAVE_SYMLINK macro. We could add something like this to
testsuite/util/testsuite_fs.h
#if defined(__MINGW32__) || defined(__MINGW64__) \
|| !defined (_GLIBCXX_HAVE_SYMLINK)
# define NO_SYMLINKS
#endif
and then use that in the tests. That way the private macro is only
checked in one place. We can do that later though.
>
> PS: Testing with trunk was somewhat impaired by various changes in the
> filesystem implementation and tests that cause new failures on rtems6
The only significant changes are for PR104161 but the directory
iterators did change fairly significantly.
Which tests are failing? I might be able to point you to the cause
much faster than you can debug it yourself.
next prev parent reply other threads:[~2022-06-22 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:13 Alexandre Oliva
2022-06-22 9:25 ` Jonathan Wakely [this message]
2022-06-22 10:42 ` Jonathan Wakely
2022-06-23 3:41 ` Alexandre Oliva
2022-06-23 10:53 ` Alexandre Oliva
2022-06-23 11:39 ` Jonathan Wakely
2022-06-23 11:02 ` Alexandre Oliva
2022-06-23 11:28 ` Jonathan Wakely
2022-06-23 11:29 ` Jonathan Wakely
2022-06-23 12:35 ` Alexandre Oliva
2022-06-23 12:37 ` Jonathan Wakely
2022-06-24 2:32 ` Alexandre Oliva
2022-06-27 13:29 ` Alexandre Oliva
2022-06-27 13:36 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=kLa=HcDLd26_1FhX2Uz5Nr5wut3r34kbM-XWcQEuKXw@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).