Re: [PATCH] libstdc++: testsuite: test symlnks ifdef _GLIBCXX_HAVE_SYMLINK

[Jonathan Wakely <jwakely@redhat.com>]

On Mon, 27 Jun 2022 at 14:29, Alexandre Oliva <oliva@adacore.com> wrote:
>
> On Jun 23, 2022, Alexandre Oliva <oliva@adacore.com> wrote:
>
> > libstdc++: testsuite: conditionalize symlink tests
>
>
> libstdc++: testsuite: conditionalize another symlink test
>
> In the recent patch that introduced NO_SYMLINKS, I missed one of the
> testcases that created symlinks.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6.  Ok to install?

OK.


>
>
>
> for  libstdc++-v3/ChangeLog
>
>         * testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc
>         (test06): Don't create symlinks when NO_SYMLINKS is defined.
> ---
>  .../iterators/recursive_directory_iterator.cc      |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc b/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc
> index e67e2cf38f754..e2f3613a3d07e 100644
> --- a/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc
> +++ b/libstdc++-v3/testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc
> @@ -187,7 +187,7 @@ test05()
>  void
>  test06()
>  {
> -#if !(defined __MINGW32__ || defined __MINGW64__)
> +#ifndef NO_SYMLINKS
>    auto p = __gnu_test::nonexistent_path();
>    create_directories(p/"d1/d2");
>    create_directory_symlink("d1", p/"link");
>
>
> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>
>