From: Jonathan Wakely <jwakely@redhat.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories
Date: Mon, 14 Nov 2022 14:13:16 +0000 [thread overview]
Message-ID: <CACb0b4kQPgCFmydn3ywTiHnVUStyD-9CG9E8pStCRD70=YPZBg@mail.gmail.com> (raw)
In-Reply-To: <86wn7xvfj1.fsf@aarsen.me>
On Mon, 14 Nov 2022 at 13:20, Arsen Arsenović <arsen@aarsen.me> wrote:
>
> Hi,
>
> Jonathan Wakely <jwakely@redhat.com> writes:
> >> This looks simple, and more consistent with what we already do. Does
> >> it solve your issue?
>
> It does work; though, if I was more daring I'd have said that it's fine
> without checking, too, since it does the same operation on the same
> directory ;)
>
> Was the omission of the mkdir $(DESTDIR)$(toolexeclibdir) intentional?
It's the first thing the recipe does:
install-data-local: gdb.py
@$(mkdir_p) $(DESTDIR)$(toolexeclibdir)
That's why I'm suggesting to do the same thing for the debug dir.
> I only see TELD/debug in your revision of the patch. Chances are, it
> gets created elsewhere (my test was just install-target-libstdc++-v3, so
> not even the full install), but it might be worth being conservative
> about it.
>
> Thanks,
> --
> Arsen Arsenović
next prev parent reply other threads:[~2022-11-14 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 18:05 Arsen Arsenović
2022-11-13 19:42 ` Jonathan Wakely
2022-11-13 20:29 ` Bernhard Reutner-Fischer
2022-11-14 10:16 ` Jonathan Wakely
2022-11-14 10:29 ` Jonathan Wakely
2022-11-14 10:39 ` Jonathan Wakely
2022-11-14 13:15 ` Arsen Arsenović
2022-11-14 14:13 ` Jonathan Wakely [this message]
2022-11-14 14:19 ` Jonathan Wakely
2022-11-14 15:56 ` Arsen Arsenović
2022-11-14 16:00 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4kQPgCFmydn3ywTiHnVUStyD-9CG9E8pStCRD70=YPZBg@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).