From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories
Date: Sun, 13 Nov 2022 19:42:52 +0000 [thread overview]
Message-ID: <CAH6eHdThkJcdRjUnPHUTU0-scxUcweO19VKbgA7ooCxYnmEpig@mail.gmail.com> (raw)
In-Reply-To: <20221113180527.2907744-1-arsen@aarsen.me>
[-- Attachment #1: Type: text/plain, Size: 3440 bytes --]
On Sun, 13 Nov 2022, 18:06 Arsen Arsenović via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
> I'm unsure why this issue only started manifesting now with how old this
> code is, but this should fix it.
>
I just pushed a change to how the debug build makefiles are generated,
which presumably uncovered this latent bug. I'll review the patch in the
morning.
> libstdc++-v3/ChangeLog:
>
> * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA
> when installing gdb scripts.
> * python/Makefile.in: Regenerate.
> ---
> Hi,
>
> Someone spotted on IRC spotted an error: if trying to install to a fresh
> prefix/sysroot with --enable-libstdcxx-debug, the install fails since it's
> intended target directories don't exist. I could replicate this on
> r13-3944-g43435c7eb0ff60 using
>
> $ ../gcc/configure --disable-bootstrap \
> --enable-libstdcxx-debug \
> --enable-languages=c,c++ \
> --prefix=$(pwd)/pfx
>
> Install tested on x86_64-pc-linux-gnu with and without
> --enable-libstdcxx-debug.
>
> libstdc++-v3/python/Makefile.am | 4 ++++
> libstdc++-v3/python/Makefile.in | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/libstdc++-v3/python/Makefile.am
> b/libstdc++-v3/python/Makefile.am
> index f523d3a44dc..7987d33e6d9 100644
> --- a/libstdc++-v3/python/Makefile.am
> +++ b/libstdc++-v3/python/Makefile.am
> @@ -58,9 +58,13 @@ install-data-local: gdb.py
> libname=`sed -ne "/^old_library=/{s/.*='//;s/'$$//;s/ .*//;p;}" \
> $(DESTDIR)$(toolexeclibdir)/libstdc++.la`; \
> fi; \
> + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)"; \
> + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir); \
> echo " $(INSTALL_DATA) gdb.py
> $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py"; \
> $(INSTALL_DATA) gdb.py
> $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py ; \
> if [ -n "$(debug_gdb_py)" ]; then \
> sed "/^libdir = /s;'$$;/debug';" gdb.py > debug-gdb.py ; \
> + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug"; \
> + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug; \
> $(INSTALL_DATA) debug-gdb.py
> $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \
> fi
> diff --git a/libstdc++-v3/python/Makefile.in
> b/libstdc++-v3/python/Makefile.in
> index 05e79b5ac1e..a68c1836481 100644
> --- a/libstdc++-v3/python/Makefile.in
> +++ b/libstdc++-v3/python/Makefile.in
> @@ -623,10 +623,14 @@ install-data-local: gdb.py
> libname=`sed -ne "/^old_library=/{s/.*='//;s/'$$//;s/ .*//;p;}" \
> $(DESTDIR)$(toolexeclibdir)/libstdc++.la`; \
> fi; \
> + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)"; \
> + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir); \
> echo " $(INSTALL_DATA) gdb.py
> $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py"; \
> $(INSTALL_DATA) gdb.py
> $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py ; \
> if [ -n "$(debug_gdb_py)" ]; then \
> sed "/^libdir = /s;'$$;/debug';" gdb.py > debug-gdb.py ; \
> + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug"; \
> + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug; \
> $(INSTALL_DATA) debug-gdb.py
> $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \
> fi
>
> --
> 2.38.1
>
>
next prev parent reply other threads:[~2022-11-13 19:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 18:05 Arsen Arsenović
2022-11-13 19:42 ` Jonathan Wakely [this message]
2022-11-13 20:29 ` Bernhard Reutner-Fischer
2022-11-14 10:16 ` Jonathan Wakely
2022-11-14 10:29 ` Jonathan Wakely
2022-11-14 10:39 ` Jonathan Wakely
2022-11-14 13:15 ` Arsen Arsenović
2022-11-14 14:13 ` Jonathan Wakely
2022-11-14 14:19 ` Jonathan Wakely
2022-11-14 15:56 ` Arsen Arsenović
2022-11-14 16:00 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdThkJcdRjUnPHUTU0-scxUcweO19VKbgA7ooCxYnmEpig@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).